All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <mlord@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Ric Wheeler <ric@emc.com>, Linux-ide <linux-ide@vger.kernel.org>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: faulty disk testing
Date: Tue, 05 Sep 2006 09:48:43 -0400	[thread overview]
Message-ID: <44FD803B.3040000@pobox.com> (raw)
In-Reply-To: <44FD662A.6060404@gmail.com>

Tejun Heo wrote:
>
> So, no, libata won't drop a drive unless it fails to respond to recovery 
> sequence.  libata just doesn't have enough information about how devices 
> are used to determine whether a device is failing too often to be useful.

Sure it does.  It can determine the number of consecutive failures on
the same drive/channel, and it can also count intervening successes, if any.

>From that, at a minimum, it could notice that the same drive has gone 'round
the error treadmill (say) 20 times in a row, with no other I/O possible on it
because it has yet to successfully complete the reset+reinit phase.

Such a drive is a candidate for pushing the error upstairs,
and possibly for getting offlined.

Fancier fault-handling is also possible, but the bare minimum is that we
must not get stuck forever looping in the EH code.  Eventually a failed status
has to be returned to the layers above, I think.

Cheers
-- 
Mark Lord
Real-Time Remedies Inc.
mlord@pobox.com


  parent reply	other threads:[~2006-09-05 13:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05  1:30 faulty disk testing Ric Wheeler
2006-09-05 11:57 ` Tejun Heo
2006-09-05 12:46   ` Ric Wheeler
2006-09-05 13:48   ` Mark Lord [this message]
2006-09-05 14:08     ` Tejun Heo
2006-09-05 14:15       ` Mark Lord
2006-09-05 14:45         ` Tejun Heo
2006-09-05 14:19       ` Ric Wheeler
2006-09-05 14:56         ` Tejun Heo
2006-09-05 15:48           ` Ric Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FD803B.3040000@pobox.com \
    --to=mlord@pobox.com \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=ric@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.