[Xenomai-core] Re: Move rtdm_irq_enable close to rtdm_irq_request

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

Dmitry Adamushko wrote:
> On 06/09/06, Jan Kiszka <jan.kiszka@domain.hid> wrote:
>>
>> See attached patch: XENO_OPT_SHIRQ would just be a menu-enabler without
>> any affect outside kconfig. You could enabled it and leave the rest off
>> (makes no sense of course) - as long as there are no edge-triggered
>> users around.
> 
> 
> 
> 
> -menu "Shared interrupts"
>> +menuconfig XENO_OPT_SHIRQ
>> +       bool "Shared interrupts"
>>
>> config XENO_OPT_SHIRQ_LEVEL
>>         bool "Level-triggered interrupts"
>> -       default n
>> +       depends on XENO_OPT_SHIRQ
>> +       default y
>>         help
>> -
>> +
>>         Enables support for shared level-triggered interrupts, so that
>>         multiple real-time interrupt handlers are allowed to control
>>         dedicated hardware devices which are configured to share
>> @@ -369,7 +371,8 @@ config XENO_OPT_SHIRQ_LEVEL
>>
>> config XENO_OPT_SHIRQ_EDGE
>>         bool "Edge-triggered interrupts"
>> -       default n
>> +       depends on XENO_OPT_SHIRQ
>> +       default y
>>         help
> 
> 
> So a user may end up with XENO_OPT_SHIRQ being enabled while both LEVEL and
> EDGE are disabled? Maybe it's worth to make LEVEL "y" by default as it's
> likely to be a required option?
> 

Do you see the "default y" above, no? :)

I thought about making only XENO_OPT_SHIRQ_LEVEL default y, but at least
for poor x86 users on legacy hardware (ISA) sharing takes at least as
often place with edge-triggered sources.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]