From: "Tantilov, Emil S" <emil.s.tantilov@intel.com>
To: Luigi Rizzo <lrizzo@google.com>, <intel-wired-lan@lists.osuosl.org>
Cc: <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
"Luigi Rizzo" <rizzo.unipi@gmail.com>,
Brian Vazquez <brianvv@google.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH iwl-next] libeth, idpf: use GFP_KERNEL for the initial Rx ring fill
Date: Mon, 19 Oct 2026 09:53:23 -0700 [thread overview]
Message-ID: <44cc348f-f548-4496-bfb2-ad9dfdee2c74@intel.com> (raw)
In-Reply-To: <20261016151835.2500807-1-lrizzo@google.com>
On 10/16/2026 8:18 AM, Luigi Rizzo wrote:
> libeth_rx_alloc() always allocates with GFP_ATOMIC, including when idpf
> fills its Rx rings at open or on queue reconfiguration. That fill runs
> in process context, right after page_pool_create() and before the
> queues' NAPI is enabled, so it may sleep, and GFP_ATOMIC is needlessly
> restrictive there: it can neither reclaim nor compact, while the initial
> fill can allocate tens of thousands of buffers across all queues.
>
> Add libeth_rx_alloc_gfp(), which takes the allocation flags, and make
> libeth_rx_alloc() its GFP_ATOMIC wrapper. Use GFP_KERNEL for the initial
> fill in idpf.
>
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>
> ---
> .../ethernet/intel/idpf/idpf_singleq_txrx.c | 7 +++---
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 9 +++++---
> drivers/net/ethernet/intel/idpf/idpf_txrx.h | 2 +-
> include/net/libeth/rx.h | 23 +++++++++++++++----
Since libeth is outside the driver, it may be better as a separate patch?
> 4 files changed, 30 insertions(+), 11 deletions(-)
Reviewed-by: Emil Tantilov <emil.s.tantilov@intel.com>
Thanks,
Emil
prev parent reply other threads:[~2026-10-19 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 15:18 [PATCH iwl-next] libeth, idpf: use GFP_KERNEL for the initial Rx ring fill Luigi Rizzo
2026-10-19 16:53 ` Tantilov, Emil S [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44cc348f-f548-4496-bfb2-ad9dfdee2c74@intel.com \
--to=emil.s.tantilov@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=brianvv@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rizzo.unipi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.