From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 69AC53C7DEB for ; Mon, 17 Aug 2026 15:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786979547; cv=none; b=DahzP6yphD8mbimV17X0YIEUH2RMKKMTspwQbgmiP8f+nARvIvse2+gD5udm0lUIJnConskWkRBcl84JU0eWnqQWX0mQuc5btiEWeJC8AK05Q3E3CzYJ8LHSsPeg9+ApcpJ8XcLJMVeIcL7/4JZ2naAcKheECt6NkjmZNuF08Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786979547; c=relaxed/simple; bh=SbZm9X+mRtNNbTef9XWXfpE6SD77RIAaE9pWNJa7ec4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SOu8dvwLhH7UvhEea/6c2oWoJR5oEU7j3jEGzweghzqAg2dk54jOw6ahLshDr65XZedRqfGvYIxvA5Nut8UTbYBjdMtHKbNICXrgrE1yd8eNqTWVbhAuKCRlV0WyupkStuVyfeK3T0FmEsnynsjs3s30EFox62u7QAmjz+S4zCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=Td0+vMAP; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="Td0+vMAP" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBD6B1655; Mon, 17 Aug 2026 08:12:21 -0700 (PDT) Received: from [10.57.6.69] (unknown [10.57.6.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D4B53F673; Mon, 17 Aug 2026 08:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786979545; bh=SbZm9X+mRtNNbTef9XWXfpE6SD77RIAaE9pWNJa7ec4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Td0+vMAP7XqOUyQnUZw2oa7rbd7/aeVddWouUHYOi7fpPNoPdtwxLk1R2xIJVWc7n D8F8QiVK9FRUhhxGM/Gn592f2s99d5QIk4n592JYJBgw7b8TmaSXmdq+Z8rKIN7k9X /Mg4piIao+fv5pp0sMZiC/Zm37+Bdf9oCrraiH+w= Message-ID: <44deb321-aa09-44f1-beb9-86a4d7eea1f4@arm.com> Date: Mon, 17 Aug 2026 16:12:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/9] drm/panthor: Get rid of panthor_group::fatal_lock To: Boris Brezillon , Liviu Dudau , Chia-I Wu Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260811-panthor-signal-from-irq-v6-0-12f2ab53d735@collabora.com> <20260811-panthor-signal-from-irq-v6-5-12f2ab53d735@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20260811-panthor-signal-from-irq-v6-5-12f2ab53d735@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/08/2026 12:23, Boris Brezillon wrote: > This lock is never used, and we're about to make fatal_queues an > atomic to cope with concurrent updates. > > Signed-off-by: Boris Brezillon Reviewed-by: Steven Price Although it does make me wonder if there's a fix that needs backporting... Thanks, Steve > --- > drivers/gpu/drm/panthor/panthor_sched.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index baa06731797c..9adf1e21eb83 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -565,9 +565,6 @@ struct panthor_group { > /** @idle_queues: Bitmask reflecting the idle queues. */ > u32 idle_queues; > > - /** @fatal_lock: Lock used to protect access to fatal fields. */ > - spinlock_t fatal_lock; > - > /** @fatal_queues: Bitmask reflecting the queues that hit a fatal exception. */ > u32 fatal_queues; > > @@ -3675,7 +3672,6 @@ int panthor_group_create(struct panthor_file *pfile, > if (!group) > return -ENOMEM; > > - spin_lock_init(&group->fatal_lock); > kref_init(&group->refcount); > group->state = PANTHOR_CS_GROUP_CREATED; > group->csg_id = -1; >