All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Helt" <krzysztof.h1@wp.pl>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] sparc dbri: recording is back
Date: Thu, 24 Aug 2006 08:09:26 +0200	[thread overview]
Message-ID: <44ed42960731f@wp.pl> (raw)
In-Reply-To: <44ec9a1bf3034@wp.pl> <s5hirkjwc4w.wl%tiwai@suse.de>



Dnia 23-08-2006 o godz. 20:16 Takashi Iwai napisał(a):
> At Wed, 23 Aug 2006 20:10:35 +0200,
> Krzysztof Helt wrote:
> > 
> > @@ -2159,7 +2139,7 @@ static snd_pcm_uframes_t snd_dbri_pointe
> >  	snd_pcm_uframes_t ret;
> >  
> >  	ret = bytes_to_frames(substream->runtime, info->offset)
> > -		% substream->runtime->buffer_size;
>  >+		% (substream->runtime->buffer_size + 1);
> >  	dprintk(D_USR, "I/O pointer: %ld frames of %ld.\n",
> >  		ret, substream->runtime->buffer_size);
> >  	return ret;
> 
> What is the reason of this change?  The original code looks OK
to me.
> The pointer callback must return a value between 0 and
> (buffer_size-1).
> 
> 

I will recheck if recording works without this change. The last
returned pointer value is equal to buffer_size. Your email
implies that 0 means "I have full buffer filled with data".

Regards,
Krzysztof

----------------------------------------------------
Oglądaj -> Wydarzenia.wp.pl -> Wiesz, co najważniejsze!
Najbardziej aktualne materiały filmowe - Kliknij:
http://klik.wp.pl/?adr=www.wydarzenia.wp.pl&sid=848



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  reply	other threads:[~2006-08-24  6:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-23 18:10 [PATCH] sparc dbri: recording is back Krzysztof Helt
2006-08-23 18:16 ` Takashi Iwai
2006-08-24  6:09   ` Krzysztof Helt [this message]
2006-08-24  9:21     ` Takashi Iwai
2006-08-25 17:58 ` Krzysztof Helt
2006-08-28 11:10   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ed42960731f@wp.pl \
    --to=krzysztof.h1@wp.pl \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.