From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Subject: Re: [PATCH] ucode debug status via sysfs for wireless-2.6 Date: Thu, 07 Sep 2006 08:21:14 -0500 Message-ID: <45001CCA.1000304@lwfinger.net> References: <20060904205340.GB3726@tuba> <20060905181232.GA4733@tuba> <44FF772A.5000301@lwfinger.net> <200609071033.52258.mb@bu3sch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Martin Langer , bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, John Linville Return-path: To: Michael Buesch In-Reply-To: <200609071033.52258.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bcm43xx-dev-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: bcm43xx-dev-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Michael Buesch wrote: > On Thursday 07 September 2006 03:34, Larry Finger wrote: >> + return -EPERM; >> + > > you want to take the spinlock lock here, too. Obviously, I copied the wrong model. Is it correct that one should take both locks if your code will touch the hardware, but the mutex lock only is sufficient if your code just accesses data structures? This seems to be the pattern in the other bcm43xx_attr_xxxx_show routines. Larry