From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] simplify the code to dump the conntrack table Date: Thu, 07 Sep 2006 17:13:19 +0200 Message-ID: <4500370F.5050002@trash.net> References: <45001B82.4000504@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Harald Welte , Netfilter Development Mailinglist Return-path: To: Pablo Neira Ayuso In-Reply-To: <45001B82.4000504@netfilter.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Pablo Neira Ayuso wrote: > Merge the bits to dump the conntrack table and the ones to dump and > zero counters in a single piece of code. This patch does not change > the default behaviour if accounting is not enabled. Nice cleanup, thanks. And it saves me from removing the id based dumping, which I forgot to change for the counter case :) BTW, what about my last question regarding your early_drop patch?