All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Edward Goggin <egoggin@emc.com>
Cc: dm-devel@redhat.com, agk@redhat.com
Subject: Re: 1st of 2 patches for dm_emc.c and dm-multipath hardware handler interface
Date: Fri, 08 Sep 2006 12:21:19 -0500	[thread overview]
Message-ID: <4501A68F.8050708@cs.wisc.edu> (raw)
In-Reply-To: <6CCEAEDF4D06984A83F427424F47D6E4013D1397@CORPUSMX40A.corp.emc.com>

Edward Goggin wrote:
> +
> +	rq->buffer = rq->data = h->buffer;
> +	rq->data_len = len;
> +	rq->bio = rq->biotail = NULL;
>  

I think I only suggested that you use the block layer map functions in
the previous review. Now I will say, use them and fix the core code to
not allocate memory or use a mempool since it will also fix the path
testers at the same time :) The reason is that the scsi layer is trying
to make every thing run with scatterlists. In 2.6.18, every place is
converted (they should be at least), so you should not be adding another
place where we send down a data buffer like this.

  reply	other threads:[~2006-09-08 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-31 14:32 1st of 2 patches for dm_emc.c and dm-multipath hardware handler interface Edward Goggin
2006-09-08 17:21 ` Mike Christie [this message]
2006-09-08 17:59   ` Mike Christie
2006-09-11 10:43     ` Hannes Reinecke
2006-09-11 17:34     ` Edward Goggin
2006-09-11 19:29       ` Mike Christie
2006-09-11 22:23         ` Mike Christie
2006-10-04 20:13   ` Edward Goggin
2006-10-05 18:09     ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4501A68F.8050708@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=egoggin@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.