From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] raw/skeleton: fix failing test case
Date: Mon, 01 Jul 2019 20:03:23 +0200 [thread overview]
Message-ID: <4502927.5MotF66W6e@xps> (raw)
In-Reply-To: <20190621155659.29297-2-bruce.richardson@intel.com>
21/06/2019 17:56, Bruce Richardson:
> Rawdev unit test for setting and getting parameters is failing because
> of a pointer value being dereferenced after the memory it pointed to is
> freed.
>
> The freeing of the malloced memory is difficult when using asserts to
> cause early abort of the test cases, since that can leak memory. The
> original placement of the free call caused a memory leak if the test
> finished early, while a fix for that leak caused the test to fail at
> times due to the memory variable being referenced after free. For a case
> like this, using stack rather than heap memory is just easier and avoids
> all issues.
>
> Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
> Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure")
> Cc: shreyansh.jain@nxp.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
This test is already fixed by another patch:
http://git.dpdk.org/dpdk/commit/?id=dcb1595956
next prev parent reply other threads:[~2019-07-01 18:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 17:08 [dpdk-dev] [PATCH 0/2] rawdev autotest fixes Bruce Richardson
2019-06-19 17:08 ` [dpdk-dev] [PATCH 1/2] raw/skeleton: fix failing test case Bruce Richardson
2019-06-19 17:08 ` [dpdk-dev] [PATCH 2/2] app/test: add missing rawdev autotest to meson build Bruce Richardson
2019-06-21 15:56 ` [dpdk-dev] [PATCH v2 0/4] fixes and improvements for rawdev Bruce Richardson
2019-06-21 15:56 ` [dpdk-dev] [PATCH v2 1/4] raw/skeleton: fix failing test case Bruce Richardson
2019-06-27 11:50 ` Hemant Agrawal
2019-07-01 18:03 ` Thomas Monjalon [this message]
2019-06-21 15:56 ` [dpdk-dev] [PATCH v2 2/4] app/test: add missing rawdev test to meson build Bruce Richardson
2019-07-01 18:10 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-06-21 15:56 ` [dpdk-dev] [PATCH v2 3/4] raw/skeleton: remove compile-time constant for device id Bruce Richardson
2019-06-21 15:56 ` [dpdk-dev] [PATCH v2 4/4] rawdev: pass device id as parameter to selftest Bruce Richardson
2019-07-04 9:33 ` Shreyansh Jain
2019-07-02 9:56 ` [dpdk-dev] [PATCH v3 0/3] fixes and improvements for rawdev Bruce Richardson
2019-07-02 9:56 ` [dpdk-dev] [PATCH v3 1/3] app/test: add missing rawdev autotest to meson build Bruce Richardson
2019-07-02 9:56 ` [dpdk-dev] [PATCH v3 2/3] raw/skeleton: remove compile-time constant for device id Bruce Richardson
2019-07-02 9:56 ` [dpdk-dev] [PATCH v3 3/3] rawdev: pass the device id as parameter to selftest Bruce Richardson
2019-07-02 15:05 ` [dpdk-dev] [PATCH v3 0/3] fixes and improvements for rawdev Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4502927.5MotF66W6e@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.