Re: [PATCH] simplify the code to dump the conntrack table

[Pablo Neira Ayuso <pablo@netfilter.org>]

Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> Merge the bits to dump the conntrack table and the ones to dump and
>> zero counters in a single piece of code. This patch does not change
>> the default behaviour if accounting is not enabled.
> 
> Nice cleanup, thanks. And it saves me from removing the id based
> dumping, which I forgot to change for the counter case :)

Thanks. So I guess that the next question is if there is any plan to
remove the id ;)

> BTW, what about my last question regarding your early_drop patch?

Sorry, I forgot to do it, please mangle the patch and use '>' instead of
'>=', otherwise the maximum number of conntracks will be ip_conntrack_max-1.

BTW, did you have the chance to have a look these patches?

http://lists.netfilter.org/pipermail/netfilter-devel/2006-August/025345.html
http://lists.netfilter.org/pipermail/netfilter-devel/2006-August/025353.html

@Jozsef: I forgot to include you in the CC, the second patch above
touches some of your TCP tracking bits '[PATCH 2/3][CONNTRACK] Introduce
the pickup facilities to take over TCP connections'

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris