From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC PATCH 1/3] dt-bindings: display: bridge: lvds-transmitter: add ti, ds90c185 Date: Tue, 20 Mar 2018 15:52:28 +0200 Message-ID: <4505095.GfTyCNF5lz@avalon> References: <20180317221525.18534-1-peda@axentia.se> <20180317221525.18534-2-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180317221525.18534-2-peda@axentia.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Rosin Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Daniel Vetter List-Id: devicetree@vger.kernel.org SGkgUGV0ZXIsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFN1bmRheSwgMTggTWFyY2gg MjAxOCAwMDoxNToyMyBFRVQgUGV0ZXIgUm9zaW4gd3JvdGU6Cj4gU3RhcnQgbGlzdCBvZiBhY3R1 YWwgY2hpcHMgY29tcGF0aWJsZSB3aXRoICJsdmRzLWVuY29kZXIiLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IFBldGVyIFJvc2luIDxwZWRhQGF4ZW50aWEuc2U+Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVl L2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMtdHJhbnNtaXR0ZXIudHh0ICAgICAgIHwgNSAr KysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdAo+ IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMt dHJhbnNtaXR0ZXIudHh0Cj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlz cGxheS9icmlkZ2UvbHZkcy10cmFuc21pdHRlci50eHQKPiBpbmRleCBmZDM5YWQzNGMzODMuLjlk MDkxOTBkOTIxMCAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9icmlkZ2UvbHZkcy10cmFuc21pdHRlci50eHQKPiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvbHZkcy10cmFuc21pdHRlci50 eHQKPiBAQCAtMjQsNiArMjQsMTEgQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiAKPiAgLSBjb21w YXRpYmxlOiBNdXN0IGJlICJsdmRzLWVuY29kZXIiCj4gCj4gKwkgICAgICBLbm93biBhY3R1YWwg Y2hpcHMgKHRoZXNlIHNob3VsZCBzdGlsbCB1c2UgImx2ZHMtZW5jb2RlciIgYXMgYQo+ICsJICAg ICAgZmFsbGJhY2sgY29tcGF0aWJsZSkgaW5jbHVkZToKPiArCj4gKwkgICAgICAidGksZHM5MGMx ODUiCgpUaGUgd29yZGluZyBzb3VuZHMgYSBiaXQgc3RyYW5nZSB0byBtZS4gSG93IGFib3V0Cgog LSBjb21wYXRpYmxlOiBNdXN0IGJlIG9uZSBvciBtb3JlIG9mIHRoZSBmb2xsb3dpbmcKICAgLSAi dGksZHM5MGMxODUiIGZvciB0aGUgVEkgRFM5MEMxODUgRlBELUxpbmsgU2VyaWFsaXplcgogICAt ICJsdmRzLWVuY29kZXIiIGZvciBhIGdlbmVyaWMgTFZEUyBlbmNvZGVyIGRldmljZQoKICAgV2hl biBjb21wYXRpYmxlIHdpdGggdGhlIGdlbmVyaWMgdmVyc2lvbiBub2RlcyBtdXN0IGxpc3QgdGhl CiAgIGRldmljZS1zcGVjaWZpYyB2ZXJzaW9uIGNvcnJlc3BvbmRpbmcgdG8gdGhlIGRldmljZSBm aXJzdAogICBmb2xsb3dlZCBieSB0aGUgZ2VuZXJpYyB2ZXJzaW9uLgoKPiAgUmVxdWlyZWQgbm9k ZXM6Cj4gCj4gIFRoaXMgZGV2aWNlIGhhcyB0d28gdmlkZW8gcG9ydHMuIFRoZWlyIGNvbm5lY3Rp b25zIGFyZSBtb2RlbGVkIHVzaW5nIHRoZSBPRgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNo YXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbeCTNv2 (ORCPT ); Tue, 20 Mar 2018 09:51:28 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:34061 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753395AbeCTNvX (ORCPT ); Tue, 20 Mar 2018 09:51:23 -0400 From: Laurent Pinchart To: Peter Rosin Cc: linux-kernel@vger.kernel.org, David Airlie , Rob Herring , Mark Rutland , Archit Taneja , Andrzej Hajda , Daniel Vetter , Gustavo Padovan , Sean Paul , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 1/3] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 Date: Tue, 20 Mar 2018 15:52:28 +0200 Message-ID: <4505095.GfTyCNF5lz@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180317221525.18534-2-peda@axentia.se> References: <20180317221525.18534-1-peda@axentia.se> <20180317221525.18534-2-peda@axentia.se> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, Thank you for the patch. On Sunday, 18 March 2018 00:15:23 EET Peter Rosin wrote: > Start list of actual chips compatible with "lvds-encoder". > > Signed-off-by: Peter Rosin > --- > .../devicetree/bindings/display/bridge/lvds-transmitter.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > index fd39ad34c383..9d09190d9210 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > @@ -24,6 +24,11 @@ Required properties: > > - compatible: Must be "lvds-encoder" > > + Known actual chips (these should still use "lvds-encoder" as a > + fallback compatible) include: > + > + "ti,ds90c185" The wording sounds a bit strange to me. How about - compatible: Must be one or more of the following - "ti,ds90c185" for the TI DS90C185 FPD-Link Serializer - "lvds-encoder" for a generic LVDS encoder device When compatible with the generic version nodes must list the device-specific version corresponding to the device first followed by the generic version. > Required nodes: > > This device has two video ports. Their connections are modeled using the OF -- Regards, Laurent Pinchart