All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Don Fry <brazilnut@us.ibm.com>
Cc: tsbogend@alpha.franken.de, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] pcnet32: NAPI implementation
Date: Mon, 11 Sep 2006 09:01:59 -0400	[thread overview]
Message-ID: <45055E47.5010303@pobox.com> (raw)
In-Reply-To: <20060908223954.GA24364@us.ibm.com>

Don Fry wrote:
> Implement NAPI changes to pcnet32 driver.  Compile default is off.
> Listed as experimental.
> 
> Len and Don both worked on a NAPI implementation and have both tested
> these changes. 
> 
> An e1000 blasting short packets to the pcnet32 will lockup Don's system
> until the receive storm stops.  Without NAPI Len's system watchdog would
> expire causing the system to reboot.  With NAPI the system will stay
> operational.
> 
> Tested ia32 and ppc64.  Tested '970A, '971, '972, '973, '975, '976, and
> '978.
> 
> The Kconfig changes came from Len.  Don is to blame for all the others.
> 
> Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
> Signed-off-by: Don Fry <brazilnut@us.ibm.com>

Please break this up into two patches:  one patch breaks code out into 
separate functions, but does not functionality at all.  second patch 
implements NAPI.

otherwise OK

	Jeff




      reply	other threads:[~2006-09-11 13:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-08 22:39 [PATCH 1/2] pcnet32: NAPI implementation Don Fry
2006-09-11 13:01 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45055E47.5010303@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=brazilnut@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.