From: jim.cromie@gmail.com (Jim Cromie)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [patch] hwmon/pc87360: update vrm setting using
Date: Mon, 11 Sep 2006 23:47:59 +0000 [thread overview]
Message-ID: <4505F5AF.7090708@gmail.com> (raw)
pc87360 currently hardcodes vrm = 90 (2.4 vintage). Update it to use
newer code in hwmon-vid which reads cpuid to determine the correct vid.
Signed-off-by: Jim Cromie <jim.cromie at gmail.com>
---
My board has an NSC SC-1100 (a 586-mmx class cpu), which is seen as
unknown,
so perhaps theres more to do / investigate, but 'unknown' is certainly
accurate at this point.
Looking at hwmon-vid.c, I note:
- it looks rather complete, at least for pentium 2 and up
- there are no i586's listed, from any vendor.
- I couldnt find anything at Intel website, or elsewhere
I reluctantly conclude that no VID standard existed back then.
Anyone have better / contradicting info ?
pc87360.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -ruNp -X dontdiff -X exclude-diffs ../linux-2.6.18-rc6-sk/drivers/hwmon/pc87360.c vrm/drivers/hwmon/pc87360.c
--- ../linux-2.6.18-rc6-sk/drivers/hwmon/pc87360.c 2006-08-14 21:19:24.000000000 -0600
+++ vrm/drivers/hwmon/pc87360.c 2006-09-11 13:55:15.000000000 -0600
@@ -917,7 +917,7 @@ static int pc87360_detect(struct i2c_ada
(i&0x02) ? "external" : "internal");
data->vid_conf = confreg[3];
- data->vrm = 90;
+ data->vrm = vid_which_vrm();
}
/* Fan clock dividers may be needed before any data is read */
next reply other threads:[~2006-09-11 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 23:47 Jim Cromie [this message]
2006-09-21 8:41 ` [lm-sensors] [patch] hwmon/pc87360: update vrm setting using Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4505F5AF.7090708@gmail.com \
--to=jim.cromie@gmail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.