From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH] connect.c: finish_connect(): allow null pid parameter
Date: Tue, 12 Sep 2006 11:00:13 +0200 [thread overview]
Message-ID: <4506771D.9040605@innova-card.com> (raw)
In-Reply-To: <450673B7.8050704@innova-card.com>
git_connect() can return 0 if we use git protocol for example.
Users of this function don't know and don't care if a process
had been created or not, and to avoid them to check it before
calling finish_connect() this patch allows finish_connect() to
take a null pid. And in that case return 0.
Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
---
Found it when debugging 'git archive --remote=git://...'
command. I noticed that this command always exited with 1 as
status.
connect.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/connect.c b/connect.c
index 1c6429b..e6efff9 100644
--- a/connect.c
+++ b/connect.c
@@ -737,6 +737,9 @@ int git_connect(int fd[2], char *url, co
int finish_connect(pid_t pid)
{
+ if (pid == 0)
+ return 0;
+
while (waitpid(pid, NULL, 0) < 0) {
if (errno != EINTR)
return -1;
--
1.4.2
next prev parent reply other threads:[~2006-09-12 9:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-10 7:09 [PATCH 1/2] archive: allow remote to have more formats than we understand Junio C Hamano
2006-09-10 7:12 ` [PATCH 2/2] Add --verbose to git-archive Junio C Hamano
2006-09-10 10:36 ` [PATCH 1/3] Move sideband client side support into reusable form Junio C Hamano
2006-09-10 19:15 ` Franck Bui-Huu
2006-09-10 10:37 ` [PATCH] Move sideband server " Junio C Hamano
2006-09-10 10:47 ` [PATCH 3/3] Add sideband status report to git-archive protocol Junio C Hamano
2006-09-10 15:58 ` [PATCH] git-upload-archive: add config option to allow only specified formats Rene Scharfe
2006-09-10 16:12 ` Rene Scharfe
2006-09-10 18:00 ` Junio C Hamano
2006-09-11 21:41 ` Rene Scharfe
2006-09-11 21:50 ` Jakub Narebski
2006-09-10 19:07 ` Franck Bui-Huu
2006-09-11 21:55 ` Rene Scharfe
2006-09-10 19:15 ` [PATCH 3/3] Add sideband status report to git-archive protocol Franck Bui-Huu
2006-09-10 20:31 ` Junio C Hamano
2006-09-11 10:34 ` Franck Bui-Huu
2006-09-12 7:24 ` Junio C Hamano
2006-09-12 8:17 ` Franck Bui-Huu
2006-09-12 8:45 ` Franck Bui-Huu
2006-09-12 9:00 ` Franck Bui-Huu [this message]
2006-09-13 4:48 ` [PATCH] connect.c: finish_connect(): allow null pid parameter Junio C Hamano
2006-09-13 8:26 ` [PATCH] Test return value of finish_connect() Franck Bui-Huu
2006-09-13 8:32 ` [PATCH] git_connect: change return type to pid_t Franck Bui-Huu
2006-09-12 23:44 ` [PATCH 3/3] Add sideband status report to git-archive protocol Junio C Hamano
2006-09-10 12:05 ` [PATCH 1/2] archive: allow remote to have more formats than we understand Rene Scharfe
2006-09-10 19:02 ` Franck Bui-Huu
2006-09-10 19:07 ` Junio C Hamano
2006-09-10 19:18 ` Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4506771D.9040605@innova-card.com \
--to=vagabon.xyz@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.