From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: PAE is_guest_l2_slot() Date: Tue, 12 Sep 2006 16:51:54 +0200 Message-ID: <4506C98A.1060305@suse.de> References: <4506D993.76E4.0078.0@novell.com> <4506C362.10403@suse.de> <4506E094.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4506E094.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >>>> Gerd Hoffmann 12.09.06 16:25 >>> >> Jan Beulich wrote: >>> Could anyone help me understand what the meaning of the hardcoded 3 in that >>> macro is? >> xen address space window is in l2 table #3 (of 4) ... > > That's why I pointed out that the mask is 11 bits (not 2) - what you say would mean > that the constant should be 0x600 (the top 11 bits of such a va), and comparison > should be >= rather than ==. IIRC the full 11 bits are needed for L1 tables only (2 indexing into L3 and 9 indexing into L2). Has been quite some time I looked into this code ... cheers, Gerd -- Gerd Hoffmann