From: Jeff Garzik <jgarzik@pobox.com>
To: Don Fry <brazilnut@us.ibm.com>
Cc: tsbogend@alpha.franken.de, netdev@vger.kernel.org
Subject: Re: [PATCH] pcnet32: Magic number cleanup
Date: Tue, 12 Sep 2006 11:59:12 -0400 [thread overview]
Message-ID: <4506D950.9030306@pobox.com> (raw)
In-Reply-To: <20060911174713.GA3978@us.ibm.com>
Don Fry wrote:
> @@ -2701,13 +2701,10 @@ static struct net_device_stats *pcnet32_
> {
> struct pcnet32_private *lp = dev->priv;
> unsigned long ioaddr = dev->base_addr;
> - u16 saved_addr;
> unsigned long flags;
>
> spin_lock_irqsave(&lp->lock, flags);
> - saved_addr = lp->a.read_rap(ioaddr);
> lp->stats.rx_missed_errors = lp->a.read_csr(ioaddr, 112);
> - lp->a.write_rap(ioaddr, saved_addr);
> spin_unlock_irqrestore(&lp->lock, flags);
This should be in a separate patch. Even though it is mentioned in the
patch description, this change is totally out of character when looking
at the rest of the patch.
Jeff
prev parent reply other threads:[~2006-09-12 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 17:47 [PATCH] pcnet32: Magic number cleanup Don Fry
2006-09-12 15:59 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4506D950.9030306@pobox.com \
--to=jgarzik@pobox.com \
--cc=brazilnut@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.