All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@domain.hid>
To: Wolfgang Grandegger <wg@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-core] [PATCH] rtcan_mem - CAN driver for memory mapped SJA1000 controllers
Date: Tue, 12 Sep 2006 20:37:13 +0200	[thread overview]
Message-ID: <4506FE59.5070107@domain.hid> (raw)
In-Reply-To: <4506E45B.8090605@domain.hid>

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Wolfgang Grandegger wrote:
> Matthias Fuchs wrote:
>> Hi,
>>
>> here's the 2nd try:
>> - updated external clock frequency handling
>> - use request_mem_region() before remapping memory
>> - renamed local variable mem to vmem in clean loop because it shadowed
>> a    
>> module parameter
> 
> I have one more comment, sorry. I think you should use:
> 
>     volatile void __iomem *vmem;
> 
> and the cleanup in case of error is not OK. See below.

Could someone post a new, full patch so that I don't mess anything up on
the way into SVN?

Thanks,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

  reply	other threads:[~2006-09-12 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-12 11:30 [Xenomai-core] [PATCH] rtcan_mem - CAN driver for memory mapped SJA1000 controllers Matthias Fuchs
2006-09-12 12:21 ` Jan Kiszka
2006-09-12 12:22 ` Wolfgang Grandegger
2006-09-12 12:38   ` Jan Kiszka
2006-09-12 13:52     ` Wolfgang Grandegger
2006-09-12 13:13   ` Matthias Fuchs
2006-09-12 13:57     ` Wolfgang Grandegger
2006-09-12 14:25       ` Jan Kiszka
2006-09-12 16:07   ` Matthias Fuchs
2006-09-12 16:46     ` Wolfgang Grandegger
2006-09-12 18:37       ` Jan Kiszka [this message]
2006-09-12 19:05       ` Matthias Fuchs
2006-09-12 20:42         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4506FE59.5070107@domain.hid \
    --to=jan.kiszka@domain.hid \
    --cc=wg@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.