Re: [PATCH] simplify the code to dump the conntrack table

[Patrick McHardy <kaber@trash.net>]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
> 
>>Pablo Neira Ayuso wrote:
>>
>>>Merge the bits to dump the conntrack table and the ones to dump and
>>>zero counters in a single piece of code. This patch does not change
>>>the default behaviour if accounting is not enabled.
>>
>>Nice cleanup, thanks. And it saves me from removing the id based
>>dumping, which I forgot to change for the counter case :)
> 
> 
> Thanks. So I guess that the next question is if there is any plan to
> remove the id ;)


I think that question has been discussed enough. Lets get rid of it.
Small complaint about this patch btw, it didn't compile without
conntrack accounting since the counters are only present when it is
enabled.

>>BTW, what about my last question regarding your early_drop patch?
> 
> 
> Sorry, I forgot to do it, please mangle the patch and use '>' instead of
> '>=', otherwise the maximum number of conntracks will be ip_conntrack_max-1.

Done, thanks.

> BTW, did you have the chance to have a look these patches?
> 
> http://lists.netfilter.org/pipermail/netfilter-devel/2006-August/025345.html

Not yet.

> http://lists.netfilter.org/pipermail/netfilter-devel/2006-August/025353.html

There were a couple of questions, still waiting for your response.