All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Albert Cahalan <acahalan@gmail.com>
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] i386/x86_64 signal handler arg fixes
Date: Thu, 14 Sep 2006 09:23:56 -0700	[thread overview]
Message-ID: <4509821C.2050502@zytor.com> (raw)
In-Reply-To: <787b0d920609140901l46ce6cd3l400c33e74a67b8db@mail.gmail.com>

Albert Cahalan wrote:
> 
>> > Currently you remap signals. Whatever you do this for
>> > regparm(0) should also be done for regparm(3).
>>
>> Not sure I parse you here. You're asking how to fix the regparm(3)
>> case?
> 
> No. I'd thought that the two cases should match.
> The regparm(3) case should remap signals if and only if
> the regparm(0) case remaps signals. Perhaps this
> is not correct if the remapping is not needed for
> native Linux apps; I doubt iBCS stuff would ever be
> needing regparm(3) support.
> 

The two should definitely match, though.  Otherwise, life will be confusing.

> Since you plan to delete the remapping cruft from
> the regparm(0) case, then obviously it should not
> be added to the regparm(3) case.

Indeed.

	-hpa

      reply	other threads:[~2006-09-14 16:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14  8:34 [PATCH] i386/x86_64 signal handler arg fixes Albert Cahalan
2006-09-14 10:11 ` Andi Kleen
2006-09-14 15:01   ` Albert Cahalan
2006-09-14 13:40     ` Andi Kleen
2006-09-14 16:01       ` Albert Cahalan
2006-09-14 16:23         ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4509821C.2050502@zytor.com \
    --to=hpa@zytor.com \
    --cc=acahalan@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.