From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] cpustate patch
Date: Thu, 14 Sep 2006 23:23:50 +0200 [thread overview]
Message-ID: <4509C866.2070909@bellard.org> (raw)
In-Reply-To: <564d96fb0609141348y3bf4bbaat539cea1694c5c02d@mail.gmail.com>
Rafael Espíndola wrote:
> While hunting a tls related bug in ARM emulation, I found that that
> qemu distributed with scratchbox includes the attached patch.
>
> Without the patch python's configure halts when checking for the
> -pthread option.
>
> The patch inverts the order of the list and makes the code simpler. I
> think that there is a remaining problem, if first_cpu == NULL then
> env->cpu_index is not initialized. Should an else be added?
>
> Any thoughts on the patch?
For consistency I prefer that the first cpu of the list is number zero,
so I prefer to leave the code as it is now.
Regards,
Fabrice.
prev parent reply other threads:[~2006-09-14 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 20:48 [Qemu-devel] cpustate patch Rafael Espíndola
2006-09-14 21:23 ` Fabrice Bellard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4509C866.2070909@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.