All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org
Subject: Re: [PATCH] powerpc: minor fix of numa message
Date: Sat, 16 Sep 2006 10:35:33 -0700	[thread overview]
Message-ID: <450C35E5.4040605@am.sony.com> (raw)
In-Reply-To: <1158282267.10020.2.camel@localhost.localdomain>

Michael Ellerman wrote:
> On Thu, 2006-09-14 at 08:17 -0700, Geoff Levand wrote:
>> This is a very minor fix that effects no current system.  The NUMA startup
>> message values for 'Top of RAM' and 'Memory hole size' were reported
>> incorrectly if more than one lmb region was added.
>> 
>> A comment in the lmb code states that lmb_analyze() must be called before
>> lmb_phys_mem_size().
> 
> But we've already called it in early_init_devtree()?

Yes, of course you are correct.  Updated patch follows.

-Geoff


This is a very minor comment change to the powerpc lbm code reflect current
usage.

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>

---

Index: cell--common--4/arch/powerpc/mm/lmb.c
===================================================================
--- cell--common--4.orig/arch/powerpc/mm/lmb.c
+++ cell--common--4/arch/powerpc/mm/lmb.c
@@ -285,7 +285,9 @@
 	return base;
 }
 
-/* You must call lmb_analyze() before this. */
+/* You must call lmb_analyze() sometime before this, typcally just after
+ * adding regions.
+ */
 unsigned long __init lmb_phys_mem_size(void)
 {
 	return lmb.memory.size;

      reply	other threads:[~2006-09-16 17:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 15:17 [PATCH] powerpc: minor fix of numa message Geoff Levand
2006-09-15  1:04 ` Michael Ellerman
2006-09-16 17:35   ` Geoff Levand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450C35E5.4040605@am.sony.com \
    --to=geoffrey.levand@am.sony.com \
    --cc=anton@samba.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.