All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hashem Masoud <masoudh@batelco.com.bh>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] olympic.c: Checks for return values
Date: Sun, 17 Sep 2006 13:21:12 +0000	[thread overview]
Message-ID: <450D4BC8.1000108@batelco.com.bh> (raw)
In-Reply-To: <450BB893.6030001@batelco.com.bh>

Alexey Dobriyan wrote:

> That's almost it. However if you follow goto you'll notice that zero
> will be returned which is not a proper indication of error.
> 
> Ergo, I need you to propagate error from register_netdev(),
> read http://mbligh.org/linuxdocs/Email/Clients/Thunderbird , then send
> proper inline patch with proper Signed-off-by line (without "at", normal
> email). Also, you need to buy Thunderbird voodoo doll.
> 
> 
> 

Thanks, this is the newest patch:

Signed-off-by: Hashem Masoud <masoudh@batelco.com.bh>
--- 
--- linux-2.6.17.13/drivers/net/tokenring/olympic.c     2006-09-09 06:23:24.000000000 +0300
+++ olympic.c   2006-09-17 15:47:18.293705248 +0300
@@ -265,7 +265,11 @@ static int __devinit olympic_probe(struc
        SET_NETDEV_DEV(dev, &pdev->dev);

        pci_set_drvdata(pdev,dev) ;
-       register_netdev(dev) ;
+
+       if ((i = register_netdev(dev))) {
+               goto op_free_iomap;
+       }
+
        printk("Olympic: %s registered as: %s\n",olympic_priv->olympic_card_name,dev->name);
        if (olympic_priv->olympic_network_monitor) { /* Must go after register_netdev as we need the device name */
                char proc_name[20] ;



I got the Thunderbird voodoo doll! But mutt is just too hard ;-)

-- 
Hashem Masoud
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2006-09-17 13:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-16  8:40 [KJ] [PATCH] olympic.c: Checks for return values Hashem Masoud
2006-09-16  9:14 ` Frederik Deweerdt
2006-09-16 14:18 ` Hashem Masoud
2006-09-16 15:46 ` Alexey Dobriyan
2006-09-17 13:21 ` Hashem Masoud [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450D4BC8.1000108@batelco.com.bh \
    --to=masoudh@batelco.com.bh \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.