From: Patrick McHardy <kaber@trash.net>
To: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite
Date: Tue, 19 Sep 2006 09:37:08 +0200 [thread overview]
Message-ID: <450F9E24.50705@trash.net> (raw)
In-Reply-To: <200609190825.35251@strip-the-willow>
Gerrit Renker wrote:
> Basic xfrm and netfilter support for UDP-Lite:
> * matching of UDP-Lite packets
> * LOG support
> * header file support
>
> --
> --- a/net/netfilter/xt_multiport.c
> +++ b/net/netfilter/xt_multiport.c
> @@ -161,8 +161,9 @@ check(u_int16_t proto,
> u_int8_t count)
> {
> /* Must specify supported protocol, no unknown flags or bad count */
> - return (proto == IPPROTO_TCP || proto == IPPROTO_UDP
> - || proto == IPPROTO_SCTP || proto == IPPROTO_DCCP)
> + return ( proto == IPPROTO_TCP ||
> + proto == IPPROTO_UDP || proto == IPPROTO_UDPLITE ||
> + proto == IPPROTO_SCTP || proto == IPPROTO_DCCP )
> && !(ip_invflags & XT_INV_PROTO)
> && (match_flags == XT_MULTIPORT_SOURCE
> || match_flags == XT_MULTIPORT_DESTINATION
The patch looks good besides the fancy formating above. I'm not too
much of a fan of the existing formating, but please keep it consistent.
next prev parent reply other threads:[~2006-09-19 7:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 16:19 [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support Gerrit Renker
2006-07-15 13:33 ` Herbert Xu
2006-07-16 9:29 ` Gerrit Renker
2006-07-28 5:30 ` David Miller
2006-07-28 8:19 ` Gerrit Renker
2006-07-28 8:25 ` David Miller
2006-09-19 7:25 ` [PATCHv3 1/4][RFC] net/ipv4: consolidated UDP / UDP-Lite code Gerrit Renker
2006-10-09 9:51 ` [PATCH-update][RFC] net: " Gerrit Renker
2006-10-11 2:38 ` David Miller
2006-10-11 7:40 ` Gerrit Renker
2006-10-12 7:49 ` Gerrit Renker
2006-10-12 9:01 ` David Miller
2006-10-13 15:14 ` [PATCHv4 1/3] net/ipv4: UDP-Lite support (RFC 3828) Gerrit Renker
2006-10-13 15:14 ` [PATCHv4 2/3] net/ipv6: v6-side of UDP-Lite Gerrit Renker
2006-10-13 15:14 ` [PATCHv4 3/3] net: UDP-Lite misc files Gerrit Renker
2006-09-19 7:25 ` [PATCHv3 2/4][RFC] net/ipv4: self-contained UDP-Lite module Gerrit Renker
2006-09-19 7:25 ` [PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite Gerrit Renker
2006-09-19 7:37 ` Patrick McHardy [this message]
2006-09-19 7:25 ` [PATCHv3 4/4][RFC] net: misc. files to support UDP-Lite Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450F9E24.50705@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.