From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures
Date: Tue, 19 Sep 2006 10:32:37 +0200 [thread overview]
Message-ID: <450FAB25.3010303@suse.de> (raw)
In-Reply-To: <20060918190155.GE17670@infradead.org>
Christoph Hellwig wrote:
> On Fri, Sep 15, 2006 at 03:34:32PM +0100, Alan Cox wrote:
>> Signed-off-by: Alan Cox <alan@redhat.com>
>>
>> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c linux-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c
>> --- linux.vanilla-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c 2006-09-11 17:00:17.000000000 +0100
>> +++ linux-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c 2006-09-14 16:50:25.000000000 +0100
>> @@ -9194,7 +9194,7 @@
>> for (i = 0; i < ARRAY_SIZE(aic_pdevs); i++)
>> {
>> pdev = NULL;
>> - while ((pdev = pci_find_device(aic_pdevs[i].vendor_id,
>> + while ((pdev = pci_get_device(aic_pdevs[i].vendor_id,
>> aic_pdevs[i].device_id,
>
> NACK. This doesn't help us forward at all. In case you have
> the hardware please do a full conversion to the real pci probing API.
>
Ceterum censeo.
Why can't we just remove this driver? It pretty much obsoleted by now, or?
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux Products GmbH S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2006-09-19 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 14:34 [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures Alan Cox
2006-09-18 19:01 ` Christoph Hellwig
2006-09-18 19:45 ` Alan Cox
2006-09-19 2:10 ` Doug Ledford
2006-09-19 8:32 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450FAB25.3010303@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.