From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Alison Schofield <amsfield22@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: wilc1000: host_interface: remove unused semaphores
Date: Fri, 19 Feb 2016 09:11:35 +0100 [thread overview]
Message-ID: <4510768.RHHeBtvDZW@wuerfel> (raw)
In-Reply-To: <20160219064551.GB2364@d830.WORKGROUP>
On Thursday 18 February 2016 22:45:53 Alison Schofield wrote:
> On Tue, Feb 16, 2016 at 09:33:38AM +0100, Arnd Bergmann wrote:
> > On Tuesday 16 February 2016 00:30:35 Alison Schofield wrote:
> > > Remove unused semaphore declarations, initializations, and unlocks.
> > >
> > > The functions that locked these semaphores were previously removed,
> > > so this cleans up the remains.
> > >
> > > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > >
> >
> > Nice!
> >
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> I'm wondering if I should have cleaned this area up more. I was
> cleaning up the semaphores because the functions that locked those
> HOST_IF_MSG's has been removed. However, the "handlers" for these
> returned HOST_IF_MSG's still exist, as does the case in the
> hostIFthread() switch.
>
> They seem like artifacts, but then again, they could be needed for
> some pass-thru mode.
>
> Leave it, clean it, or seek more info?
Maybe do one patch, and Cc the maintainers on that patch. From looking
at the history, I'm quite sure that this is also dead code.
My understanding is that this was originally part of an operating-system
independent library abstraction for a larger set of devices. The driver
is being stripped down to only support Linux and only a couple
of devices, and that has left tons of code that is never called.
Arnd
next prev parent reply other threads:[~2016-02-19 8:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 8:27 [PATCH 0/3] staging: wilc1000: semaphores to mutexes in host_interface Alison Schofield
2016-02-16 8:30 ` [PATCH 1/3] staging: wilc1000: host_interface: remove unused semaphores Alison Schofield
2016-02-16 8:33 ` [Outreachy kernel] " Arnd Bergmann
2016-02-19 6:45 ` Alison Schofield
2016-02-19 8:11 ` Arnd Bergmann [this message]
2016-02-16 8:31 ` [PATCH 2/3] staging: wilc1000: host_interface: replace semaphores with mutexes Alison Schofield
2016-02-16 8:46 ` [Outreachy kernel] " Arnd Bergmann
2016-02-16 17:36 ` Greg KH
2016-02-16 18:16 ` Alison Schofield
2016-02-16 21:34 ` [Outreachy kernel] " Arnd Bergmann
2016-02-19 19:42 ` Alison Schofield
2016-02-19 19:45 ` [PATCH] staging: wilc1000: replace semaphore get_inactive_time with a completion Alison Schofield
2016-02-19 21:03 ` [Outreachy kernel] " Arnd Bergmann
2016-02-20 0:54 ` Greg KH
2016-02-20 1:06 ` Alison Schofield
2016-02-20 1:13 ` Greg KH
2016-02-16 8:36 ` [PATCH 3/3] staging: wilc1000: host_interface: destroy mutexes at init/deinit Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4510768.RHHeBtvDZW@wuerfel \
--to=arnd@arndb.de \
--cc=amsfield22@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.