From: Arjan van de Ven <arjan@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] rtc: lockdep fix
Date: Wed, 20 Sep 2006 16:49:18 +0800 [thread overview]
Message-ID: <4511008E.5090005@linux.intel.com> (raw)
In-Reply-To: <20060920082135.GB12517@elte.hu>
Ingo Molnar wrote:
> * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>
>> BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted)
>> [<c04051ee>] show_trace_log_lvl+0x58/0x171
>> [<c0405802>] show_trace+0xd/0x10
>> [<c040591b>] dump_stack+0x19/0x1b
>> [<c043abee>] trace_hardirqs_on+0xa2/0x11e
>> [<c06143c3>] _spin_unlock_irq+0x22/0x26
>> [<c0541540>] rtc_get_rtc_time+0x32/0x176
>> [<c0419ba4>] hpet_rtc_interrupt+0x92/0x14d
>> [<c0450f94>] handle_IRQ_event+0x20/0x4d
>> [<c0451055>] __do_IRQ+0x94/0xef
>> [<c040678d>] do_IRQ+0x9e/0xbd
>> [<c0404a49>] common_interrupt+0x25/0x2c
>
> ouch! That is a scenario that could lead to real lockups. Fix looks good
> and necessary for v2.6.18 to me.
>
btw this entire code path is evil; the rtc_get_rtc_time() function can do really long delays
which is unsuitable for being called in interrupt context!
next prev parent reply other threads:[~2006-09-20 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 19:54 [PATCH] rtc: lockdep fix/workaround Peter Zijlstra
2006-09-20 8:21 ` [PATCH] rtc: lockdep fix Ingo Molnar
2006-09-20 8:49 ` Arjan van de Ven [this message]
2006-09-20 8:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4511008E.5090005@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.