From: Henne <henne@nachtwindheim.de>
To: Christoph Hellwig <hch@infradead.org>, Henne <henne@nachtwindheim.de>
Cc: Andrew Morton <akpm@osdl.org>,
James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi-driver ultrastore replace Scsi_Cmnd with struct scsi_cmnd
Date: Wed, 20 Sep 2006 11:57:50 +0200 [thread overview]
Message-ID: <4511109E.4050103@nachtwindheim.de> (raw)
In-Reply-To: <20060918185321.GB17670@infradead.org>
>>On Wed, Sept 06, 2006 at 10:49:48AM +0200, Henne wrote:From: Henrik Kretzschmar <henne@nachtwindheim.de>
>>
>>Replaces the typedef'd Scsi_Cmnd with struct scsi_cmnd.
>>Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
>Looks good to me. It would be even better if you could update the
>driver to not require
>
> #include "scsi.h"
>
>anymore and get rid of ultrastor.h. Also your mailer unfortunately
>damages tabs.
Sure, thats the big goal for all scsi drivers,but I decided to do one step after another.
I think it would be better to remove Scsi_Cmnd first to remove drivers/scsi/scsi_typedefs.h
first and then make the drivers use the headers in include/scsi/.
This is imho clearer to have one target per patch.
1. - change Scsi_Cmnd to struct scsi_cmnd
remove scsi_typedefs.h from drivers/scsi/scsi.h
remove scsi_typedefs.h from the tree
2. - put the local headers into c files if only used
by the driver itself (maybe delete unneeded prototypes or reorder the functions that no prototypes are needed)
3. - switch over to include/scsi/
Thats is my opinion.
>Also your mailer unfortunately damages tabs.
No, it doesn't. Even if it thunderbird. :)
ultrastor.h uses 4 spaces as intention and I just forgot to replace the with a tab.
Thanks.
But I'm still looking for an easy standalone commandline smtp-engine to send my patches. Any suggestions?
Greets,
Henne
prev parent reply other threads:[~2006-09-20 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 8:49 [PATCH] scsi-driver ultrastore replace Scsi_Cmnd with struct scsi_cmnd Henne
2006-09-18 18:53 ` Christoph Hellwig
2006-09-20 9:57 ` Henne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4511109E.4050103@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.