Re: [NETFILTER 05/39]: ipt_TCPMSS: remove impossible condition

[Roberto Nibali <ratz@drugphish.ch>]

> [NETFILTER]: ipt_TCPMSS: remove impossible condition
> 
> Every skb must have a dst_entry at this point.

[...]

> diff --git a/net/ipv4/netfilter/ipt_TCPMSS.c b/net/ipv4/netfilter/ipt_TCPMSS.c
> index bfc8d9c..b2d3c4f 100644
> --- a/net/ipv4/netfilter/ipt_TCPMSS.c
> +++ b/net/ipv4/netfilter/ipt_TCPMSS.c
> @@ -73,13 +73,6 @@ ipt_tcpmss_target(struct sk_buff **pskb,
>  	}
>  
>  	if (tcpmssinfo->mss == IPT_TCPMSS_CLAMP_PMTU) {
> -		if (!(*pskb)->dst) {
> -			if (net_ratelimit())
> -				printk(KERN_ERR "ipt_tcpmss_target: "
> -				       "no dst?! can't determine path-MTU\n");
> -			return NF_DROP; /* or IPT_CONTINUE ?? */
> -		}
> -
>  		if (dst_mtu((*pskb)->dst) <= sizeof(struct iphdr) +
>  					     sizeof(struct tcphdr)) {
>  			if (net_ratelimit())
> 

Could be a candidate for 2.4 kernels as well. Although, it's not a 
strict bugfix, only a performance improvement, at best.

Regards,
Roberto Nibali, ratz
-- 
echo 
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc