All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Horms <horms@verge.net.au>
Cc: Ken Brownfield <krb@irridia.com>,
	Roberto Nibali <ratz@drugphish.ch>,
	netfilter-devel@lists.netfilter.org,
	Farid Sarwari <fsarwari@exchangesolutions.com>,
	Julian Anastasov <ja@ssi.bg>, David Black <dave@jamsoft.com>,
	Joseph Mack NA3T <jmack@wm7d.net>,
	David Miller <davem@davemloft.net>
Subject: Re: [patch 1/3] add type parameter to ip_route_me_harder
Date: Wed, 20 Sep 2006 17:45:23 +0200	[thread overview]
Message-ID: <45116213.8010300@trash.net> (raw)
In-Reply-To: <20060920141732.GA1286@verge.net.au>

Horms wrote:
> On Wed, Sep 20, 2006 at 12:30:58PM +0200, Patrick McHardy wrote:
> 
>>I liked the RTN_ types better .. is there a reason for not using
>>them? Otherwise I'll just change it before applying.
> 
> 
> Mainly because it seemed difficult to shoe-horn into the
> reworking of ipt_REJECT's reverse_route(). In particular,
> what value should be passed for non-local? auto and local 
> are of course easy.

Just explicitly using ip_route_output on the LOCAL_IN/LOCAL_OUT
hooks (and for the bridging case) should be fine for ipt_REJECT.
A local source address can not occur in FORWARD, so ip_route_input
will be chosen through inet_addr_type. So how about:

RTN_LOCAL: route as locally originating packet
RTN_UNSPEC: use inet_addr_type to find out

I think thats also what you did in your first patch.

  reply	other threads:[~2006-09-20 15:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-19  2:45 [patch 0/3] Add addr_type to ip_route_me_harder() Horms
2006-09-19  2:45 ` [patch 1/3] add type parameter to ip_route_me_harder Horms
2006-09-20 10:30   ` Patrick McHardy
2006-09-20 14:17     ` Horms
2006-09-20 15:45       ` Patrick McHardy [this message]
2006-09-21  9:21         ` Horms
2006-09-21  9:22           ` [patch 0/3] Add addr_type to ip_route_me_harder() Horms
2006-09-21  9:22           ` [patch 1/3] add type parameter to ip_route_me_harder Horms
2006-09-21  9:22           ` [patch 2/3] Honour source routing for LVS-NAT Horms
2006-09-29 13:38             ` Patrick McHardy
2006-10-02  1:57               ` Horms
2006-09-21  9:22           ` [patch 3/3] Replace reverse_route() with a call to ip_route_me_harder() Horms
2006-09-29 13:38             ` Patrick McHardy
2006-09-19  2:45 ` [patch 2/3] Honour source routing for LVS-NAT Horms
2006-09-19  2:45 ` [patch 3/3] Replace reverse_route() with a call to ip_route_me_harder() Horms
2006-09-19  3:56   ` Horms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45116213.8010300@trash.net \
    --to=kaber@trash.net \
    --cc=dave@jamsoft.com \
    --cc=davem@davemloft.net \
    --cc=fsarwari@exchangesolutions.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=jmack@wm7d.net \
    --cc=krb@irridia.com \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=ratz@drugphish.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.