All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	bjorn_helgaas@hp.com, Nick Piggin <nickpiggin@yahoo.com.au>,
	Andrew Morton <akpm@osdl.org>, Robin Holt <holt@sgi.com>,
	Dean Nelson <dcn@sgi.com>, Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch] do_no_pfn()
Date: Wed, 20 Sep 2006 18:47:53 +0200	[thread overview]
Message-ID: <451170B9.4010101@sgi.com> (raw)
In-Reply-To: <20060920084638.900c9a69.rdunlap@xenotime.net>

Randy.Dunlap wrote:
> On 20 Sep 2006 03:25:25 -0400 Jes Sorensen wrote:
>> +#define NOPFN_SIGBUS	((unsigned long) -1)
>> +#define NOPFN_OOM	((unsigned long) -2)
> 
> Is there any difference in the above and
> 
> #define NOPFN_SIGBUS		-1UL
> #define NOPFN_OOM		-2UL

I don't think there is, but I was trying to keep it consistent with the
NOPAGE_foo versions - the way it's done is more explicit so less likely
anyone will get confused over it.

I can change it if it's a sticking point, but I'd claim thats more noise
than it's worth.

Thanks,
Jes


  reply	other threads:[~2006-09-20 16:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-20  4:33 Arrr! Linux 2.6.18 Linus Torvalds
2006-09-20  4:59 ` Michal Piotrowski
2006-09-20  7:25 ` [patch] do_no_pfn() Jes Sorensen
2006-09-20 15:46   ` Randy.Dunlap
2006-09-20 16:47     ` Jes Sorensen [this message]
2006-09-22 19:49   ` Andrew Morton
2006-09-25  9:31     ` Jes Sorensen
2006-09-22 21:51 ` Arrr! Linux 2.6.18 Judith Lebzelter
2006-09-22 22:08   ` Jeff Garzik
2006-09-22 22:57     ` Dale Farnsworth
2006-09-22 22:58       ` Jeff Garzik
2006-09-29  8:36 ` Mark Lord
2006-09-29 14:49   ` Linus Torvalds
2006-09-29  8:40 ` Mark Lord
2006-09-29  8:44   ` Andrew Morton
2006-09-29 17:52     ` Mark Lord
2006-09-29 19:42       ` Rafael J. Wysocki
2006-09-29 19:58       ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451170B9.4010101@sgi.com \
    --to=jes@sgi.com \
    --cc=akpm@osdl.org \
    --cc=bjorn_helgaas@hp.com \
    --cc=dcn@sgi.com \
    --cc=holt@sgi.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.