From: mabbas <mabbas@linux.intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 7/7] d80211: getting wrong freq value if we did hardware scan
Date: Thu, 21 Sep 2006 10:42:01 -0700 [thread overview]
Message-ID: <4512CEE9.2050106@linux.intel.com> (raw)
In-Reply-To: <20060921192934.5260dfdc@logostar.upir.cz>
Jiri Benc wrote:
> On Mon, 28 Aug 2006 13:57:28 -0700, mabbas wrote:
>
>> diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c
>> index a933d92..374193e 100644
>> --- a/net/d80211/ieee80211_sta.c
>> +++ b/net/d80211/ieee80211_sta.c
>> @@ -1543,8 +1543,6 @@ #endif
>> bss->channel = channel;
>> bss->freq = local->conf.freq;
>> if (channel != local->conf.channel &&
>> - (local->conf.phymode == MODE_IEEE80211G ||
>> - local->conf.phymode == MODE_IEEE80211B) &&
>> channel >= 1 && channel <= 14) {
>>
>
> The patch doesn't look correct. As I already wrote, no hackish guessing of
> the phymode from channel numbers, please.
>
> Are there any problems with just using rx_status->phymode instead of
> local->conf.phymode (other than "drivers don't set that field" as that can
> be easily fixed)?
>
Excellent idea here I will fix this patch to use rx_status->phymode if
set otherwise it will use the default algorithm already exist.
> Thanks,
>
> Jiri
>
>
prev parent reply other threads:[~2006-09-21 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 20:57 [PATCH 7/7] d80211: getting wrong freq value if we did hardware scan mabbas
2006-09-21 17:29 ` Jiri Benc
2006-09-21 17:42 ` mabbas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4512CEE9.2050106@linux.intel.com \
--to=mabbas@linux.intel.com \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.