All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Frank Ch. Eigler" <fche@redhat.com>,
	Mathieu Desnoyers <compudj@krystal.dyndns.org>,
	Martin Bligh <mbligh@google.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	prasanna@in.ibm.com, Andrew Morton <akpm@osdl.org>,
	Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jes Sorensen <jes@sgi.com>, Tom Zanussi <zanussi@us.ibm.com>,
	Richard J Moore <richardj_moore@uk.ibm.com>,
	Michel Dagenais <michel.dagenais@polymtl.ca>,
	Christoph Hellwig <hch@infradead.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	William Cohen <wcohen@redhat.com>,
	ltt-dev@shafik.org, systemtap@sources.redhat.com,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Linux Kernel Markers 0.5 for Linux 2.6.17 (with probe management)
Date: Thu, 21 Sep 2006 12:54:04 -0700	[thread overview]
Message-ID: <4512EDDC.2010000@goop.org> (raw)
In-Reply-To: <20060921185029.GB12048@elte.hu>

Ingo Molnar wrote:
> let me qualify that: parameters must be prepared there too - but no 
> actual function call inserted. (at most a NOP inserted). The register 
> filling doesnt even have to be function-calling-convention compliant - 
> that makes the symbolic probe almost zero-impact to register 
> allocation/scheduling, the only thing it should ensure is that the 
> parameters that are annotated to be available in register, stack or 
> memory _somewhere_. (i.e. not hidden or destroyed at that point by gcc) 
> Does a simple asm() that takes read-only parameters but only adds a NOP 
> achieve this result?

Do you mean using the asm to make sure gcc puts a reference to a 
variable into the DWARF info, or some other way of encoding the value 
locations?

Hm, another problem.  If the mark is in a loop, and gcc decides to 
unroll the loop, then you'll probably only get a mark in one iteration 
of the loop (or 1/Nth of the iterations).  Or worse, assembler errors.  
The only way I can see to deal with this is to not use symbols, but put 
records in a special section.  That way, if the asm() inserting them 
gets duplicated, you'll get duplicate records in the marker section.

I guess you'd get a similar problem with markers inserted in inlined 
functions.

(How does gdb deal with breakpoints in unrolled loops?)

    J

  reply	other threads:[~2006-09-21 19:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 16:00 [PATCH] Linux Kernel Markers 0.5 for Linux 2.6.17 (with probe management) Mathieu Desnoyers
2006-09-21 16:06 ` Ingo Molnar
2006-09-21 21:42   ` Mathieu Desnoyers
2006-09-21 21:49     ` Mathieu Desnoyers
2006-09-22  6:29     ` Karim Yaghmour
2006-09-22  6:49     ` Ingo Molnar
2006-09-22 14:03       ` Mathieu Desnoyers
2006-09-22 16:53         ` Ingo Molnar
2006-09-22 17:11           ` Mathieu Desnoyers
2006-09-22 17:12             ` Ingo Molnar
2006-09-22 17:28               ` Mathieu Desnoyers
2006-09-22  7:07     ` Ingo Molnar
2006-09-22  8:14       ` Karim Yaghmour
2006-09-22 15:08       ` Mathieu Desnoyers
2006-09-22 16:24         ` Karim Yaghmour
2006-09-22 16:13           ` Mathieu Desnoyers
2006-09-22 17:03             ` Karim Yaghmour
2006-09-22 18:06               ` Mathieu Desnoyers
2006-09-22 19:24                 ` Karim Yaghmour
2006-09-22 16:45         ` Ingo Molnar
2006-09-22 14:31     ` Christoph Hellwig
2006-09-23 16:51   ` Mathieu Desnoyers
2006-09-21 17:56 ` Frank Ch. Eigler
2006-09-21 18:50   ` Ingo Molnar
2006-09-21 19:54     ` Jeremy Fitzhardinge [this message]
2006-09-25 17:45     ` Frank Ch. Eigler
2006-09-21 20:59   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4512EDDC.2010000@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=compudj@krystal.dyndns.org \
    --cc=fche@redhat.com \
    --cc=gregkh@suse.de \
    --cc=hch@infradead.org \
    --cc=jes@sgi.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mbligh@google.com \
    --cc=michel.dagenais@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=prasanna@in.ibm.com \
    --cc=richardj_moore@uk.ibm.com \
    --cc=systemtap@sources.redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wcohen@redhat.com \
    --cc=zanussi@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.