All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Kconfig:  XT_MATCH_PHYSDEV dependency missing
@ 2006-09-22  0:32 Florin Malita
  0 siblings, 0 replies; only message in thread
From: Florin Malita @ 2006-09-22  0:32 UTC (permalink / raw)
  To: coreteam; +Cc: linux-kernel, rusty, akpm

CONFIG_BRIDGE=m && CONFIG_NETFILTER_XT_MATCH_PHYSDEV=y breaks at link time:

LD .tmp_vmlinux1
net/built-in.o: In function `checkentry':xt_physdev.c:(.text+0x223f8):
undefined reference to `brnf_deferred_hooks'
:xt_physdev.c:(.text+0x22420): undefined reference to `brnf_deferred_hooks'
make: *** [.tmp_vmlinux1] Error 1

net/netfilter/xt_physdev.c references 'brn_deferred_hooks' which is
declared in net/bridge/br_netfilter.c but CONFIG_BRIDGE=m prevents
linking br_netfilter.o in. So CONFIG_NETFILTER_XT_MATCH_PHYSDEV really
depends on CONFIG_BRIDGE and this should be enforced in netfilter's Kconfig.

Signed-off-by: Florin Malita <fmalita@gmail.com>
---

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index a9894dd..b2c412a 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -342,7 +342,7 @@ config NETFILTER_XT_MATCH_MULTIPORT
 
 config NETFILTER_XT_MATCH_PHYSDEV
 	tristate '"physdev" match support'
-	depends on NETFILTER_XTABLES && BRIDGE_NETFILTER
+	depends on NETFILTER_XTABLES && BRIDGE_NETFILTER && BRIDGE
 	help
 	  Physdev packet matching matches against the physical bridge ports
 	  the IP packet arrived on or will leave by.



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-09-22  0:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-22  0:32 [PATCH] Kconfig: XT_MATCH_PHYSDEV dependency missing Florin Malita

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.