diff for duplicates of <4513A098.4060505@gmail.com> diff --git a/a/1.txt b/N1/1.txt index fd32986..cf3d60b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -32,7 +32,7 @@ Om Narasimhan wrote: >> GFP_KERNEL); >> > + buff = kzalloc(iocommand.buf_size, >> GFP_KERNEL); ->> > if (buff = NULL) +>> > if (buff == NULL) >> > return -EFAULT; >> > } >> > @@ -911,8 +911,6 @@ #endif @@ -42,11 +42,11 @@ Om Narasimhan wrote: >> > - } else { >> > - memset(buff, 0, iocommand.buf_size); >> > } ->> > if ((c = cmd_alloc(host, 0)) = NULL) { +>> > if ((c = cmd_alloc(host, 0)) == NULL) { >> > kfree(buff); >> >> This changes performance potentially, no? The memset before was ->> conditional upon (iocommand.Request.Type.Direction = XFER_WRITE) and +>> conditional upon (iocommand.Request.Type.Direction == XFER_WRITE) and >> now the memory will always be zero'd. > Yes, but not the functionality. > if (iocommand.buf_size > 0), code allocates using kmalloc. if @@ -66,7 +66,3 @@ http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E -_______________________________________________ -Kernel-janitors mailing list -Kernel-janitors@lists.osdl.org -https://lists.osdl.org/mailman/listinfo/kernel-janitors diff --git a/a/content_digest b/N1/content_digest index 575e3db..f940609 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\06b4e42d10609212240i3d02241djbdaa0176ab9bfb2b@mail.gmail.com\0" "From\0Jiri Slaby <jirislaby@gmail.com>\0" "Subject\0Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]\0" - "Date\0Fri, 22 Sep 2006 08:36:40 +0000\0" + "Date\0Fri, 22 Sep 2006 10:36:40 +0200\0" "To\0Om Narasimhan <om.turyx@gmail.com>\0" "Cc\0Nishanth Aravamudan <nacc@us.ibm.com>" linux-kernel@vger.kernel.org @@ -44,7 +44,7 @@ ">> GFP_KERNEL);\n" ">> > + buff = kzalloc(iocommand.buf_size, \n" ">> GFP_KERNEL);\n" - ">> > if (buff = NULL)\n" + ">> > if (buff == NULL)\n" ">> > return -EFAULT;\n" ">> > }\n" ">> > @@ -911,8 +911,6 @@ #endif\n" @@ -54,11 +54,11 @@ ">> > - } else {\n" ">> > - memset(buff, 0, iocommand.buf_size);\n" ">> > }\n" - ">> > if ((c = cmd_alloc(host, 0)) = NULL) {\n" + ">> > if ((c = cmd_alloc(host, 0)) == NULL) {\n" ">> > kfree(buff);\n" ">>\n" ">> This changes performance potentially, no? The memset before was\n" - ">> conditional upon (iocommand.Request.Type.Direction = XFER_WRITE) and\n" + ">> conditional upon (iocommand.Request.Type.Direction == XFER_WRITE) and\n" ">> now the memory will always be zero'd.\n" "> Yes, but not the functionality.\n" "> if (iocommand.buf_size > 0), code allocates using kmalloc. if\n" @@ -77,10 +77,6 @@ "http://www.fi.muni.cz/~xslaby/ Jiri Slaby\n" "faculty of informatics, masaryk university, brno, cz\n" "e-mail: jirislaby gmail com, gpg pubkey fingerprint:\n" - "B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E\n" - "_______________________________________________\n" - "Kernel-janitors mailing list\n" - "Kernel-janitors@lists.osdl.org\n" - https://lists.osdl.org/mailman/listinfo/kernel-janitors + B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E -f3c891a5c4dc40796ab21536c89279e51a9d3a321e5eec278a07bff26c3360dd +6fd0ff6cc45b417eaf54df7594ebdb1fedb1adf3acd34f653800199c9b6c9483
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.