diff for duplicates of <4513A21C.40704@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 8f783b8..80e8d5e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ Om Narasimhan wrote: > if (iocommand.buf_size > 0) { > - buff = kmalloc(iocommand.buf_size, GFP_KERNEL); > + buff = kzalloc(iocommand.buf_size, GFP_KERNEL); -> if (buff = NULL) +> if (buff == NULL) > return -EFAULT; > } > @@ -911,8 +911,6 @@ #endif @@ -31,7 +31,7 @@ Om Narasimhan wrote: No. > } -> if ((c = cmd_alloc(host, 0)) = NULL) { +> if ((c = cmd_alloc(host, 0)) == NULL) { > kfree(buff); > diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c > index 78082ed..34f8e96 100644 @@ -71,10 +71,10 @@ What's this? Wrapped? kcalloc? > @@ -580,7 +578,7 @@ static int alloc_cpqarray_hba(void) > > for(i=0; i< MAX_CTLR; i++) { -> if (hba[i] = NULL) { +> if (hba[i] == NULL) { > - hba[i] = kmalloc(sizeof(ctlr_info_t), GFP_KERNEL); > + hba[i] = kzalloc(sizeof(ctlr_info_t), GFP_KERNEL); -> if(hba[i]=NULL) { +> if(hba[i]==NULL) { > printk(KERN_ERR "cpqarray: out of memory.\n"); > return (-1); > @@ -765,7 +763,6 @@ static int __init cpqarray_eisa_detect(v @@ -104,7 +104,3 @@ http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E -_______________________________________________ -Kernel-janitors mailing list -Kernel-janitors@lists.osdl.org -https://lists.osdl.org/mailman/listinfo/kernel-janitors diff --git a/a/content_digest b/N1/content_digest index 07c8809..0770f93 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\06b4e42d10609212304o52bbc9b4y434bbd7ef71281e3@mail.gmail.com\0" "From\0Jiri Slaby <jirislaby@gmail.com>\0" "Subject\0Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]\0" - "Date\0Fri, 22 Sep 2006 08:43:08 +0000\0" + "Date\0Fri, 22 Sep 2006 10:43:08 +0200\0" "To\0Om Narasimhan <om.turyx@gmail.com>\0" "Cc\0linux-kernel@vger.kernel.org" " kernel-janitors@lists.osdl.org\0" @@ -30,7 +30,7 @@ "> if (iocommand.buf_size > 0) {\n" "> - buff = kmalloc(iocommand.buf_size, GFP_KERNEL);\n" "> + buff = kzalloc(iocommand.buf_size, GFP_KERNEL);\n" - "> if (buff = NULL)\n" + "> if (buff == NULL)\n" "> return -EFAULT;\n" "> }\n" "> @@ -911,8 +911,6 @@ #endif\n" @@ -43,7 +43,7 @@ "No.\n" "\n" "> }\n" - "> if ((c = cmd_alloc(host, 0)) = NULL) {\n" + "> if ((c = cmd_alloc(host, 0)) == NULL) {\n" "> kfree(buff);\n" "> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c\n" "> index 78082ed..34f8e96 100644\n" @@ -83,10 +83,10 @@ "> @@ -580,7 +578,7 @@ static int alloc_cpqarray_hba(void)\n" "> \n" "> for(i=0; i< MAX_CTLR; i++) {\n" - "> if (hba[i] = NULL) {\n" + "> if (hba[i] == NULL) {\n" "> - hba[i] = kmalloc(sizeof(ctlr_info_t), GFP_KERNEL);\n" "> + hba[i] = kzalloc(sizeof(ctlr_info_t), GFP_KERNEL);\n" - "> if(hba[i]=NULL) {\n" + "> if(hba[i]==NULL) {\n" "> printk(KERN_ERR \"cpqarray: out of memory.\\n\");\n" "> return (-1);\n" "> @@ -765,7 +763,6 @@ static int __init cpqarray_eisa_detect(v\n" @@ -115,10 +115,6 @@ "http://www.fi.muni.cz/~xslaby/ Jiri Slaby\n" "faculty of informatics, masaryk university, brno, cz\n" "e-mail: jirislaby gmail com, gpg pubkey fingerprint:\n" - "B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E\n" - "_______________________________________________\n" - "Kernel-janitors mailing list\n" - "Kernel-janitors@lists.osdl.org\n" - https://lists.osdl.org/mailman/listinfo/kernel-janitors + B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E -9147d445b6875f5bded9466116e1c229347b0a46762167b67603e06d97d9f0a6 +468d9abebdd5e583e9ce42593ea5900f4a415b34daa7dd2f96ca99e6d1a640c5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.