All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Andrew Morton <akpm@osdl.org>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c
Date: Fri, 22 Sep 2006 12:15:43 +0200	[thread overview]
Message-ID: <4513B7CF.5040209@trash.net> (raw)
In-Reply-To: <20060922095556.GA11991@ff.dom.local>

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

Jarek Poplawski wrote:
> On Fri, Sep 22, 2006 at 11:27:31AM +0200, Jarek Poplawski wrote:
> ...
> 
>>There is CONFIG_BRIDGE=m and this is the source of a problem:
>>config shouldn't allow for:
>>
>>CONFIG_NETFILTER_BRIDGE=y 
>>CONFIG_NETFILTER_XT_MATCH_PHYSDEV=y 
> 
>  
> So here is a patch proposal.
> 
> Jarek P.
> 
> diff -Nurp linux-2.6.18-/net/Kconfig linux-2.6.18/net/Kconfig
> --- linux-2.6.18-/net/Kconfig	2006-09-20 05:42:06.000000000 +0200
> +++ linux-2.6.18/net/Kconfig	2006-09-22 11:42:19.000000000 +0200
> @@ -143,7 +143,7 @@ config NETFILTER_DEBUG
>  
>  config BRIDGE_NETFILTER
>  	bool "Bridged IP/ARP packets filtering"
> -	depends on BRIDGE && NETFILTER && INET
> +	depends on BRIDGE=y && NETFILTER && INET

We should fix the physdev dependencies since this is what is causing
problems.


Signed-off-by: Patrick McHardy <kaber@trash.net>

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 511 bytes --]

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 0a28d2c..ce94732 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -365,7 +365,7 @@ config NETFILTER_XT_MATCH_MULTIPORT
 
 config NETFILTER_XT_MATCH_PHYSDEV
 	tristate '"physdev" match support'
-	depends on NETFILTER_XTABLES && BRIDGE_NETFILTER
+	depends on NETFILTER_XTABLES && BRIDGE && BRIDGE_NETFILTER
 	help
 	  Physdev packet matching matches against the physical bridge ports
 	  the IP packet arrived on or will leave by.

  reply	other threads:[~2006-09-22 10:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 22:37 Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c Andrew Morton
2006-09-22  8:03 ` Jarek Poplawski
2006-09-22  8:20   ` Jarek Poplawski
2006-09-22  8:41 ` Jarek Poplawski
2006-09-22  9:27   ` Jarek Poplawski
2006-09-22  9:55     ` [PATCH] " Jarek Poplawski
2006-09-22 10:15       ` Patrick McHardy [this message]
2006-09-22 10:51         ` Jarek Poplawski
2006-09-22 10:54           ` Patrick McHardy
2006-09-22 11:48             ` Jarek Poplawski
2006-09-22 11:58               ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4513B7CF.5040209@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=jarkao2@o2.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.