All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <4513C8F7.2020608@grupopie.com>

diff --git a/a/1.txt b/N1/1.txt
index 2882b44..a6976fc 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -33,7 +33,7 @@ Jiri Slaby wrote:
 >>> GFP_KERNEL);
 >>> > +                             buff = kzalloc(iocommand.buf_size, 
 >>> GFP_KERNEL);
->>> >                               if (buff = NULL)
+>>> >                               if (buff == NULL)
 >>> >                                       return -EFAULT;
 >>> >                       }
 >>> > @@ -911,8 +911,6 @@ #endif
@@ -43,11 +43,11 @@ Jiri Slaby wrote:
 >>> > -                     } else {
 >>> > -                             memset(buff, 0, iocommand.buf_size);
 >>> >                       }
->>> >                       if ((c = cmd_alloc(host, 0)) = NULL) {
+>>> >                       if ((c = cmd_alloc(host, 0)) == NULL) {
 >>> >                               kfree(buff);
 >>>
 >>> This changes performance potentially, no? The memset before was
->>> conditional upon (iocommand.Request.Type.Direction = XFER_WRITE) and
+>>> conditional upon (iocommand.Request.Type.Direction == XFER_WRITE) and
 >>> now the memory will always be zero'd.
 >> Yes, but not the functionality.
 >> if (iocommand.buf_size > 0), code allocates using kmalloc. if
@@ -67,7 +67,3 @@ Paulo Marques - www.grupopie.com
 
 "The face of a child can say it all, especially the
 mouth part of the face."
-_______________________________________________
-Kernel-janitors mailing list
-Kernel-janitors@lists.osdl.org
-https://lists.osdl.org/mailman/listinfo/kernel-janitors
diff --git a/a/content_digest b/N1/content_digest
index d01f01e..c0e0e02 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -4,7 +4,7 @@
  "ref\04513A098.4060505@gmail.com\0"
  "From\0Paulo Marques <pmarques@grupopie.com>\0"
  "Subject\0Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]\0"
- "Date\0Fri, 22 Sep 2006 11:28:55 +0000\0"
+ "Date\0Fri, 22 Sep 2006 12:28:55 +0100\0"
  "To\0Jiri Slaby <jirislaby@gmail.com>\0"
  "Cc\0Om Narasimhan <om.turyx@gmail.com>"
   Nishanth Aravamudan <nacc@us.ibm.com>
@@ -47,7 +47,7 @@
  ">>> GFP_KERNEL);\n"
  ">>> > +                             buff = kzalloc(iocommand.buf_size, \n"
  ">>> GFP_KERNEL);\n"
- ">>> >                               if (buff = NULL)\n"
+ ">>> >                               if (buff == NULL)\n"
  ">>> >                                       return -EFAULT;\n"
  ">>> >                       }\n"
  ">>> > @@ -911,8 +911,6 @@ #endif\n"
@@ -57,11 +57,11 @@
  ">>> > -                     } else {\n"
  ">>> > -                             memset(buff, 0, iocommand.buf_size);\n"
  ">>> >                       }\n"
- ">>> >                       if ((c = cmd_alloc(host, 0)) = NULL) {\n"
+ ">>> >                       if ((c = cmd_alloc(host, 0)) == NULL) {\n"
  ">>> >                               kfree(buff);\n"
  ">>>\n"
  ">>> This changes performance potentially, no? The memset before was\n"
- ">>> conditional upon (iocommand.Request.Type.Direction = XFER_WRITE) and\n"
+ ">>> conditional upon (iocommand.Request.Type.Direction == XFER_WRITE) and\n"
  ">>> now the memory will always be zero'd.\n"
  ">> Yes, but not the functionality.\n"
  ">> if (iocommand.buf_size > 0), code allocates using kmalloc. if\n"
@@ -80,10 +80,6 @@
  "Paulo Marques - www.grupopie.com\n"
  "\n"
  "\"The face of a child can say it all, especially the\n"
- "mouth part of the face.\"\n"
- "_______________________________________________\n"
- "Kernel-janitors mailing list\n"
- "Kernel-janitors@lists.osdl.org\n"
- https://lists.osdl.org/mailman/listinfo/kernel-janitors
+ "mouth part of the face.\""
 
-0cec4aa5e5cd2db84a6926de8671ca1b176f3a63047a40eb0ae9bcc585302d87
+4294d184bcf36dd107547371b8367368afff2547a0574a6338cbb693fe8f2ad2

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.