All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Clements <paul.clements@steeleye.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: [PATCH] md SET_BITMAP_FILE compat ioctl
Date: Fri, 22 Sep 2006 11:29:18 -0400	[thread overview]
Message-ID: <4514014E.1060302@steeleye.com> (raw)
In-Reply-To: <4512F55D.5030907@steeleye.com>

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

The SET_BITMAP_FILE ioctl currently doesn't have a compat entry, so on 
64-bit systems a 32-bit mdadm will fail:

Sep 20 16:34:52 caspian kernel: ioctl32(mdadm:8056): Unknown cmd fd(3) 
cmd(8004092b){00} arg(00000004) on /dev/md0

The fix is to build a 64-bit mdadm or apply the following patch (compile 
tested only).

--
Paul

[-- Attachment #2: md_set_bitmap_file_compat_ioctl.diff --]
[-- Type: text/plain, Size: 400 bytes --]

--- ./include/linux/compat_ioctl.h.orig	2006-09-22 11:14:53.000000000 -0400
+++ ./include/linux/compat_ioctl.h	2006-09-22 11:15:24.000000000 -0400
@@ -121,6 +121,7 @@ ULONG_IOCTL(START_ARRAY)
 COMPATIBLE_IOCTL(STOP_ARRAY)
 COMPATIBLE_IOCTL(STOP_ARRAY_RO)
 COMPATIBLE_IOCTL(RESTART_ARRAY_RW)
+ULONG_IOCTL(SET_BITMAP_FILE)
 /* DM */
 COMPATIBLE_IOCTL(DM_VERSION_32)
 COMPATIBLE_IOCTL(DM_REMOVE_ALL_32)

  reply	other threads:[~2006-09-22 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 20:26 [BUG/PATCH] md bitmap broken on big endian machines Paul Clements
2006-09-22 15:29 ` Paul Clements [this message]
2006-09-28  7:31   ` [PATCH] md SET_BITMAP_FILE compat ioctl Neil Brown
2006-09-28  6:34 ` [BUG/PATCH] md bitmap broken on big endian machines Neil Brown
2006-09-28 22:09   ` Michael Tokarev
2006-09-29  0:48     ` Paul Clements
2006-09-29  7:03       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4514014E.1060302@steeleye.com \
    --to=paul.clements@steeleye.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.