From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: linux-lvm@redhat.com, Alasdair Kergon <agk@redhat.com>,
Jonathan Brassow <jbrassow@redhat.com>
Subject: [linux-lvm] [PATCH LVM2 2/2] fix lvconvert to setup mirror constraints
Date: Fri, 22 Sep 2006 18:33:02 -0400 [thread overview]
Message-ID: <4514649E.2040403@ce.jp.nec.com> (raw)
In-Reply-To: <45146347.3070804@ce.jp.nec.com>
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
This patch fixes this problem:
- 'lvconvert' from corelog allocates log from the same PV
with other image. It spoils redundancy.
The patch depends on fix-mirror-alloc-anywhere.patch posted formerly.
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
[-- Attachment #2: fix-lvconvert-allocate-disklog.patch --]
[-- Type: text/x-patch, Size: 953 bytes --]
diff -X dontdiff -urp LVM2/tools/lvconvert.c LVM2.fixed/tools/lvconvert.c
--- LVM2/tools/lvconvert.c 2006-08-30 05:57:31.000000000 -0400
+++ LVM2.fixed/tools/lvconvert.c 2006-09-15 00:00:33.000000000 -0400
@@ -281,15 +281,10 @@ static int lvconvert_mirrors(struct cmd_
if (lp->mirrors == existing_mirrors) {
if (!seg->log_lv && !arg_count(cmd, corelog_ARG)) {
/* No disk log present, add one. */
- /* FIXME: Why doesn't this work? Without
- it, we will probably put the log on the
- same device as a mirror leg.
- if (!(parallel_areas = build_parallel_areas_from_lv(cmd, lv))) {
- stack;
- return 0;
- }
- */
- parallel_areas = NULL;
+ if (!(parallel_areas = build_parallel_areas_from_lv(cmd, lv))) {
+ stack;
+ return 0;
+ }
if (!lv_mirror_percent(cmd, lv, 0, &sync_percent, NULL)) {
log_error("Unable to determine mirror sync status.");
return 0;
prev parent reply other threads:[~2006-09-22 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 22:27 [linux-lvm] [PATCH LVM2 0/2] fix alloc anywhere and addition of disklog Jun'ichi Nomura
2006-09-22 22:31 ` [linux-lvm] [PATCH LVM2 1/2] fix mirror allocation Jun'ichi Nomura
2006-09-22 22:33 ` Jun'ichi Nomura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4514649E.2040403@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=agk@redhat.com \
--cc=jbrassow@redhat.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.