All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] ioremap balance with iounmap for drivers/net
Date: Mon, 25 Sep 2006 05:44:08 +0000	[thread overview]
Message-ID: <45176CA8.9030702@garzik.org> (raw)
In-Reply-To: <1158931552.25016.9.camel@amol.verismonetworks.com>

Amol Lad wrote:
>> 1) linux-net is a *user* list. you should have mailed netdev@...
> Thanks.. I'll post it to net-dev
> 
>> 2) e1000 already contains that change. Did you base your work on jgarzik's 
>> upstream tree?
> I used latest 2.6.18

That's not sufficient.  Tons of changes occur between releases.  You 
need to use the latest tree.  Since netdev#upstream went to Linus today, 
the latest is in linux-2.6.git.


>> 3) your patch includes utsrelease.h!
> This was discussed sometime back on this list, I believe. The file
> should be included in dontdiff but due to som reason it's not there...I
> never touch this file but still it's always there in the patch...

To put it bluntly, we don't care why it's there.  Make sure it isn't in 
the next time.

	Jeff



_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-09-25  5:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-22 13:37 [KJ] [PATCH] ioremap balance with iounmap for drivers/net Amol Lad
2006-09-22 14:44 ` Auke Kok
2006-09-25  4:31 ` Amol Lad
2006-09-25  5:44 ` Jeff Garzik [this message]
2006-09-25 14:09 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45176CA8.9030702@garzik.org \
    --to=jeff@garzik.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.