From: Jeff Garzik <jeff@garzik.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, a.p.zijlstra@chello.nl,
aabdulla@nvidia.com, arjan@linux.intel.com, davej@redhat.com,
mingo@elte.hu
Subject: Re: [patch 11/11] forcedeth: hardirq lockdep warning
Date: Mon, 25 Sep 2006 20:03:25 -0400 [thread overview]
Message-ID: <45186E4D.3020406@garzik.org> (raw)
In-Reply-To: <200609252339.k8PNdQKG002661@shell0.pdx.osdl.net>
akpm@osdl.org wrote:
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted)
>
> Call Trace:
> show_trace
> dump_stack
> trace_hardirqs_on
> :forcedeth:nv_nic_irq_other
> handle_IRQ_event
> __do_IRQ
> do_IRQ
> ret_from_intr
> DWARF2 barf
> default_idle
> cpu_idle
> rest_init
> start_kernel
> _sinittext
>
> These 3 functions nv_nic_irq_tx(), nv_nic_irq_rx() and nv_nic_irq_other()
> are reachable from IRQ context and process context. Make use of the
> irq-save/restore spinlock variant.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Dave Jones <davej@redhat.com>
> Cc: Ayaz Abdulla <aabdulla@nvidia.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
ACK + HOLD, must analyze locking before applying. It still looks
strange, even after this patch.
prev parent reply other threads:[~2006-09-26 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 23:39 [patch 11/11] forcedeth: hardirq lockdep warning akpm
2006-09-26 0:03 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45186E4D.3020406@garzik.org \
--to=jeff@garzik.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aabdulla@nvidia.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=davej@redhat.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.