From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH] [XEND] Remove hard tabs
Date: Tue, 26 Sep 2006 10:34:12 -0500
Message-ID: <45194874.5090903@us.ibm.com>
References: <f7d90f962967a5a94fce.1158780092@basalt.austin.ibm.com>	<62b0912f0609202258k6d399871tad27827ddb9b1137@mail.gmail.com>	<1158870493.11176.5.camel@diesel>	<62b0912f0609240350w6a3ed277p2e58536da80d8abe@mail.gmail.com>
	<1159202321.9507.17.camel@basalt.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1159202321.9507.17.camel@basalt.austin.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: xen-devel@lists.xensource.com, Molle Bestefich <molle.bestefich@gmail.com>
List-Id: xen-devel@lists.xenproject.org

Hollis Blanchard wrote:
> On Sun, 2006-09-24 at 12:50 +0200, Molle Bestefich wrote:
>   
>> Hollis Blanchard wrote:
>>     
>>> Molle Bestefich wrote:
>>>       
>>>> Hollis Blanchard:
>>>>         
>>>>> [XEND] Remove hard tabs.
>>>>>           
>>>> That's stupid, tabs are a relief to use when coding compared to spaces.
>>>>         
>>> That's a separate conversation.
>>>       
>> Seemed relevant since what you're doing is switching things originally
>> coded one way to use what *you* prefer, without changing the code at
>> all (right?).
>>     
>
> No, actually, I prefer tabs. :) However, there were ~10 lines in that
> file using tabs, with all the rest using spaces. In Python that's a more
> serious offense than in other languages.
>   

As it has been mentioned, whitespace is the right thing to do in 
python.  It's not a point of debate.

Tab-width is interpreted as 8 in Python.  This can lead to subtle bugs 
in code where people use text-editors with different width tabs.  These 
are real bugs that have actually occurred in Xen before.

There have been big patches in Xend to globally remove tabs.  Any time 
the creep back in, they ought to be removed.

For more info, see:

http://docs.python.org/ref/indentation.html

Regards,

Anthony Liguori