From: Jeff Garzik <jeff@garzik.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: netdev@vger.kernel.org, Gary Zambrano <zambrano@broadcom.com>,
akpm@osdl.org
Subject: Re: [patch 09/11] b44: fix eeprom endianess issue
Date: Tue, 26 Sep 2006 12:08:42 -0400 [thread overview]
Message-ID: <4519508A.4010004@garzik.org> (raw)
In-Reply-To: <200609261804.37422.mb@bu3sch.de>
Michael Buesch wrote:
> No it isn't. There are lots of other parameters in the ssb SPROM.
> And most of them are _not_ in bigendian.
> I think we also read the PHYport or something in b44.
> See bcm43xx or the ssb module for the rest of the values.
>
> Returning a SPROM bytearray as BABABABA is just plain wrong.
> It must always be ABABABAB, because we expect this. This patch
> encures ABABAB order on every platform. The interpret function
> must not know on which platform we are, as it's just interpreting
> the _byte_ array (byte array, without any endian semantics).
>
> This _fixes_ a bug (In the correct way, so that future bugs will
> not appear)
It's amusing to call something incorrect, when my suggested solution
will interpret the correct values from b44_get_invariants() simply by
changing the b44_get_invariants() code from reading BABABABA to ABABABAB.
Jeff
next prev parent reply other threads:[~2006-09-26 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 23:39 [patch 09/11] b44: fix eeprom endianess issue akpm
2006-09-25 23:59 ` Jeff Garzik
2006-09-26 15:47 ` Michael Buesch
2006-09-26 15:59 ` Jeff Garzik
2006-09-26 16:04 ` Michael Buesch
2006-09-26 16:08 ` Jeff Garzik [this message]
2006-09-26 16:20 ` Michael Buesch
2006-09-26 17:00 ` Jeff Garzik
2006-09-26 17:14 ` Michael Buesch
2006-09-27 7:55 ` Johannes Berg
2006-09-26 16:49 ` Johannes Berg
2006-09-26 17:49 ` Francois Romieu
2006-09-26 18:10 ` Michael Buesch
2006-09-26 19:05 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4519508A.4010004@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.