From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Olivier Galibert <galibert@pobox.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata-sff: use our IRQ defines
Date: Tue, 26 Sep 2006 17:25:43 -0400 [thread overview]
Message-ID: <45199AD7.1060805@pobox.com> (raw)
In-Reply-To: <1159305562.11049.312.camel@localhost.localdomain>
Alan Cox wrote:
> Ar Maw, 2006-09-26 am 22:44 +0200, ysgrifennodd Olivier Galibert:
>>> if (probe_ent->irq)
>>> - probe_ent->irq2 = 15;
>>> + probe_ent->irq2 = ATA_SECONDARY_IRQ;
>>> else
>>> probe_ent->irq = 15;
>> Isn't that one supposed to be ATA_SECONDARY_IRQ too?
>>
>>> probe_ent->port[1].cmd_addr = ATA_SECONDARY_CMD;
>
> Duh yes...
>
> (adds another paper bag to the pile)
committed obvious fix...
prev parent reply other threads:[~2006-09-26 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 16:55 [PATCH] libata-sff: use our IRQ defines Alan Cox
2006-09-26 17:35 ` Jeff Garzik
2006-09-26 20:44 ` Olivier Galibert
2006-09-26 21:19 ` Alan Cox
2006-09-26 21:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45199AD7.1060805@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=galibert@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.