All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <srostedt@redhat.com>
To: xen-devel@lists.xensource.com
Cc: andrew.warfield@cl.cam.ac.uk
Subject: [PATCH 0/2] clean up blktap and change to use a dynamic major
Date: Wed, 27 Sep 2006 12:16:24 -0400	[thread overview]
Message-ID: <451AA3D8.4030909@redhat.com> (raw)

The following two patches are to clean up blktap.c and to make it use a 
dynamic major instead of a hardcoded one.

The first patch does two things:

1. cleans up the style to be more compatible with the Linux Style

2. gets rid of the private data structure used in filp->private_data

The private data structure only has one item and that is the idx (index 
into the tapfds descriptors).  This is allocated on open of the device 
and freed on close.  The idx element always is the same as the minor 
number.  Instead of using this (which would not be accepted into the 
kernel), I got rid of the private structure completely and instead I 
have filp->private_data point to the descriptor itself.  This cleans up 
the code a bit.


The second patch changes the blktap to use a dynamic major.  Instead of 
a hardcoded 254, the number is dynamic, and the blktapctrl now reads 
/proc/devices to find the number to use to create the node.

NOTE:  Currently and after this patch, the blktapctrl daemon creates the 
device node. This is not the way Linux should work, and this needs to be 
done by udev.  That update should be next (after I learn how udev works :)

-- Steve

             reply	other threads:[~2006-09-27 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-27 16:16 Steven Rostedt [this message]
2006-09-27 16:19 ` [PATCH 1/2] clean up blktap and remove private structure Steven Rostedt
2006-09-28 19:05   ` Andrew Warfield
2006-09-27 16:21 ` [PATCH 2/2] have blktap use a dynamic major Steven Rostedt
2006-09-28 19:48   ` Andrew Warfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451AA3D8.4030909@redhat.com \
    --to=srostedt@redhat.com \
    --cc=andrew.warfield@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.