From: Eric Sandeen <sandeen@sandeen.net>
To: Andrew Morton <akpm@osdl.org>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>, Jan Kara <jack@suse.cz>,
Badari Pulavarty <pbadari@us.ibm.com>,
Anton Altaparmakov <aia21@cam.ac.uk>,
sct@redhat.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers
Date: Wed, 27 Sep 2006 17:01:25 -0500 [thread overview]
Message-ID: <451AF4B5.1090607@sandeen.net> (raw)
In-Reply-To: <20060913203817.b6711381.akpm@osdl.org>
Andrew Morton wrote:
> On Wed, 13 Sep 2006 15:25:19 -0500
> Dave Kleikamp <shaggy@austin.ibm.com> wrote:
>
>>> +void journal_do_submit_data(struct buffer_head **wbuf, int bufs)
>> Is there any reason this couldn't be static?
>
> Nope.
With this change, journal_brelse_array can also be made static in
recovery.c, and removed from jbd.h, I think.
-Eric
next prev parent reply other threads:[~2006-09-27 22:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 15:50 [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers Badari Pulavarty
2006-09-01 16:12 ` Anton Altaparmakov
2006-09-01 16:32 ` Badari Pulavarty
2006-09-01 17:18 ` Andrew Morton
2006-09-01 17:43 ` Badari Pulavarty
2006-09-01 21:01 ` Badari Pulavarty
2006-09-05 16:11 ` Badari Pulavarty
2006-09-06 12:47 ` Jan Kara
2006-09-06 15:12 ` Badari Pulavarty
2006-09-06 15:34 ` Jan Kara
2006-09-06 16:19 ` Badari Pulavarty
2006-09-06 16:27 ` Jan Kara
2006-09-06 16:43 ` Badari Pulavarty
2006-09-06 17:03 ` Jan Kara
2006-09-06 17:16 ` Badari Pulavarty
2006-09-06 17:27 ` Jan Kara
2006-09-07 2:14 ` Andrew Morton
2006-09-07 3:04 ` Badari Pulavarty
2006-09-07 3:34 ` Andrew Morton
2006-09-07 15:11 ` Badari Pulavarty
2006-09-07 20:48 ` Jan Kara
2006-09-07 22:30 ` Jan Kara
2006-09-08 4:33 ` Badari Pulavarty
2006-09-08 8:25 ` Jan Kara
2006-09-08 14:35 ` Badari Pulavarty
2006-09-11 9:46 ` Jan Kara
2006-09-11 20:45 ` Badari Pulavarty
2006-09-11 20:52 ` Jan Kara
2006-09-13 20:25 ` Dave Kleikamp
2006-09-14 3:38 ` Andrew Morton
2006-09-27 22:01 ` Eric Sandeen [this message]
2006-09-28 15:03 ` [PATCH] JBD: Make journal_do_submit_data static Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451AF4B5.1090607@sandeen.net \
--to=sandeen@sandeen.net \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=sct@redhat.com \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.