From: Rik van Riel <riel@redhat.com>
To: xen-devel@lists.xensource.com
Subject: Re: [Xen-changelog] [xen-unstable] [VMXASSIST] Cast to pointer type via long to avoid compile
Date: Thu, 28 Sep 2006 15:23:20 -0400 [thread overview]
Message-ID: <451C2128.7040102@redhat.com> (raw)
In-Reply-To: <E1GSfQG-0007FB-Ao@xenbits.xensource.com>
Xen patchbot-unstable wrote:
> [VMXASSIST] Cast to pointer type via long to avoid compile
> warnings/errors with latest gcc versions.
> Signed-off-by: Keir Fraser <keir@xensource.com>
Are you sure you don't want these to be unsigned, seeing that
the x86-64 kernels have the top bit set for kernel addresses?
> diff -r 5c522692edd1 -r 1d0e75523636 tools/firmware/vmxassist/vm86.c
> --- a/tools/firmware/vmxassist/vm86.c Wed Sep 27 16:22:17 2006 +0100
> +++ b/tools/firmware/vmxassist/vm86.c Wed Sep 27 17:49:22 2006 +0100
> @@ -68,7 +68,7 @@ guest_linear_to_real(uint32_t base)
> return base;
>
> if (!(oldctx.cr4 & CR4_PAE)) {
> - l1_mfn = ((uint32_t *)gcr3)[(base >> 22) & 0x3ff];
> + l1_mfn = ((uint32_t *)(long)gcr3)[(base >> 22) & 0x3ff];
--
All Rights Reversed
next parent reply other threads:[~2006-09-28 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1GSfQG-0007FB-Ao@xenbits.xensource.com>
2006-09-28 19:23 ` Rik van Riel [this message]
2006-09-28 19:53 ` Re: [Xen-changelog] [xen-unstable] [VMXASSIST] Cast to pointer type via long to avoid compile Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451C2128.7040102@redhat.com \
--to=riel@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.