From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by arago-project.org (Postfix) with ESMTPS id E0B0352968 for ; Tue, 3 Nov 2020 00:18:07 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A30ExFL063432 for ; Mon, 2 Nov 2020 18:14:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604362499; bh=txogbEG+DoncOSIQdjm7tfUwJrS87/AHY1yxfj+m63Q=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=tW6+nMS7piHnhI5o3mLd51zNU73Y5JUHqaV45vdLLbtTfUuDnF71Muz7uYLx+ol0/ 1o7pKsx/87+UMvVzRNQXZEwe9aaoek5/Ly4j1O1UbIVvWZ7uYlb6y6RqOIDey8SjGw RdzdRroQLqoJv4aeA3ky/Lc+0Hjk611y4Y640RhI= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A30ExvQ050115 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Nov 2020 18:14:59 -0600 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 2 Nov 2020 18:14:59 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 2 Nov 2020 18:14:59 -0600 Received: from [10.250.39.72] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A30Ew4o106099; Mon, 2 Nov 2020 18:14:58 -0600 To: Denys Dmytriyenko , Lucas Weaver References: <20201027024112.5330-1-s-anna@ti.com> <20201027024533.GR19741@beryl> <21098998-f191-b9f0-79af-26b1045c6a54@ti.com> <20201027040839.GS19741@beryl> <39ea11fd-e4bf-3133-b280-ece903a9b9f8@ti.com> <20201027191149.GY19741@beryl> <4469fbf2-fe4f-df39-351c-318411f9e7ed@ti.com> <20201103000508.GA3224@beryl> From: Suman Anna Message-ID: <451e7d9c-e9a9-7744-680d-59446e8907bb@ti.com> Date: Mon, 2 Nov 2020 18:14:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201103000508.GA3224@beryl> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [master/dunfell PATCH] packagegroup-arago-tisdk-addons-sdk-target: Add ti-rpmsg-char dev packages X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 00:18:08 -0000 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/2/20 6:05 PM, Denys Dmytriyenko wrote: > On Mon, Nov 02, 2020 at 04:53:56PM -0600, Suman Anna wrote: >> Hi Dan, >> >> On 11/2/20 4:18 PM, Dan Murphy wrote: >>> Suman >>> >>> On 10/27/20 2:11 PM, Denys Dmytriyenko wrote: >>>> On Tue, Oct 27, 2020 at 09:37:18AM -0500, Suman Anna wrote: >>>>> Hi Denys, >>>>> >>>>> On 10/26/20 11:08 PM, Denys Dmytriyenko wrote: >>>>>> On Mon, Oct 26, 2020 at 09:48:26PM -0500, Suman Anna wrote: >>>>>>> On 10/26/20 9:45 PM, Denys Dmytriyenko wrote: >>>>>>>> On Mon, Oct 26, 2020 at 09:41:12PM -0500, Suman Anna wrote: >>>>>>>>> Add the ti-rpmsg-char dev packages to make the public headers available in >>>>>>>>> the target fileystem so that applications can be compiled natively on the >>>>>>>>> target. >>>>>>>> -sdk-target is not for the target filesystem! >>>>>>>> It is for the target sysroot in the devkit. >>>>>>> Hmm, is this supposed to go into a different file or my patch description >>>>>>> needs >>>>>>> correcting? >>>>>> It depends on what you actually need. >>>>> I want the files from the  ti-rpmsg-char-dev package (the public header files >>>>> and libti_rpmsg_char.so) to be part of the FS tarball. >>>> Then you need to pull corresponding -dev package into the packagegroup that >>>> builds up the rootfs. >>>> >>>> At least in Arago, I kept the namespace convention that -sdk-target and >>>> -sdk-host suffixes are used to identify packagegroups for the devkit - >>>> cross-compile development environment on the host, target and host sysroots. >>>> >>>>> regards >>>>> Suman >>>>> >>>>>> >>>>>>>>> Signed-off-by: Suman Anna >>>>>>>>> --- >>>>>>>>>   .../packagegroup-arago-tisdk-addons-sdk-target.bb         | 8 ++++++-- >>>>>>>>>   1 file changed, 6 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git >>>>>>>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb >>>>>>>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb >>>>>>>>> >>>>>>>>> index e372dd67744e..b55c79a4d4df 100644 >>>>>>>>> --- >>>>>>>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb >>>>>>>>> >>>>>>>>> +++ >>>>>>>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-target.bb >>>>>>>>> >>>>>>>>> @@ -1,6 +1,6 @@ >>>>>>>>>   DESCRIPTION = "Task to install headers and libraries related to addons >>>>>>>>> into the SDK" >>>>>>>>>   LICENSE = "MIT" >>>>>>>>> -PR = "r43" >>>>>>>>> +PR = "r44" >>>>>>>>>     PACKAGE_ARCH = "${MACHINE_ARCH}" >>>>>>>>>   @@ -143,7 +143,11 @@ UTILS_append_dra7xx = " can-utils-dev \ >>>>>>>>>                           elfutils-staticdev \ >>>>>>>>>   " >>>>>>>>>   UTILS_append_k2g = " can-utils-dev" >>>>>>>>> -UTILS_append_k3 = " can-utils-dev" >>>>>>>>> +UTILS_append_k3 = "\ >>>>>>>>> +    can-utils-dev \ >>>>>>>>> +    ti-rpmsg-char-dev \ >>>>>>>>> +    ti-rpmsg-char-staticdev \ >>>>>>>>> +" >>>>>>>>>     EXTRA_LIBS = "" >>>>>>>>>   EXTRA_LIBS_append_ti43x = "\ >>>>>>>>> --  >>>>>>>>> 2.28.0 >>>>>>>>> >>> >>> Does this need to go in or are you going to send in v2? >> >> I am confused by the terminology above, I am not sure if I need to move this to >> the packagegroup-arago-tisdk-addons.bb file, or if this is just a question of >> writing the proper patch description. I cannot verify myself until I fix my OE >> build issues. > > Suman, > > If you do need these development packages on the target rootfs, then you do > need to add them to packagegroup-arago-tisdk-addons.bb > > But if you need them to be part of the devkit (cross-compile development > environment on the host), then you need to add to the corresponding > packagegroup-arago-tisdk-addons-sdk-target.bb > > In other words, do you expect someone to compile natively on the target > against your library and headers? Then it's the first one. But, enabling > native development environment on the target should not be decided lightly. > As a matter of fact, for 7.0 we removed this from the default rootfs, > expecting users to be able to add it optionally from package feeds. Though > public package feeds were not ready and got postponed... > > So, my point is - what are you trying to achieve here? Why do you need -dev > package on the target filesystem? If you are trying to enable other developers > to build apps against your library, could they just write a recipe? Is it > really necessary for the default rootfs? Anyway, hopefully these questions > could guide you towards the proper solution. Please let me know if you still > have questions :) > Thanks for the explanation Denys. The ask is to be able to compile on the target, believe for some Vision Apps. Lucas, Can you confirm/clarify the need/usage exactly? regards Suman