All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Robert Scott <rbscott@cadvium.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: nfq_set_verdict_mark
Date: Mon, 02 Oct 2006 16:55:08 +0200	[thread overview]
Message-ID: <4521284C.2070000@netfilter.org> (raw)
In-Reply-To: <986D9B66-68B6-4A02-9762-40224E145496@cadvium.net>

Robert Scott wrote:
> i noticed that this function doesn't automatically convert the mark into
> the expected network byte order.  this is a minor detail, but the
> current behavior may confuse users. since nfq_get_nfmark automatically
> converts the mark into host order, i thought nfq_set_verdict_mark would
> also  do the reverse.
> 
> not really a big deal, and this will probably break most existing
> installations in the field, but perhaps a note in the docs to give new
> users a heads up.

Yes, I agree what you, we have to document this minor issue, I think
that we can introduce more API that can solve this inconsistency.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

  reply	other threads:[~2006-10-02 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-01 20:09 nfq_set_verdict_mark Robert Scott
2006-10-02 14:55 ` Pablo Neira Ayuso [this message]
2006-10-10  5:20   ` nfq_set_verdict_mark Patrick McHardy
2006-10-10 23:59     ` nfq_set_verdict_mark Pablo Neira Ayuso
2006-10-11  9:02       ` nfq_set_verdict_mark Patrick McHardy
2006-10-11 21:47         ` nfq_set_verdict_mark Pablo Neira Ayuso
2006-10-12  6:35           ` nfq_set_verdict_mark Eric Leblond
2006-10-13  6:15             ` nfq_set_verdict_mark Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4521284C.2070000@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=rbscott@cadvium.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.