From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reiner Sailer Subject: [IMPORTANT BUGFIX][ACM][XM] FIX essential security check in block-attach / indentation problem introduced in change set changeset 11572 Date: Mon, 02 Oct 2006 23:47:28 -0400 Message-ID: <4521DD50.5060308@us.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050601000701090207030501" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: atse@xensource.com, "Bryan D. Payne" , Reiner Sailer List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------050601000701090207030501 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit This patch fixes an indentation error in main.py. The effect of this bug is that block-attach does not check labels if the ACM is active. This bug slipped in with change set 11572_:_ ad22c711ccb7 . This patch is essential and should get into 3.0.3. I tested the patch with security off and on. Thanks Reiner P.S. We are currently enhancing xm-test to include security tests so that we can detect simple things like this faster. Signed-off by: Reiner Sailer --------------050601000701090207030501 Content-Type: text/plain; name="block_attach_acm_fix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="block_attach_acm_fix.diff" --- tools/python/xen/xm/main.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: xen-unstable.hg-shype/tools/python/xen/xm/main.py =================================================================== --- xen-unstable.hg-shype.orig/tools/python/xen/xm/main.py +++ xen-unstable.hg-shype/tools/python/xen/xm/main.py @@ -1222,7 +1222,8 @@ def parse_block_configuration(args): label = security.get_security_printlabel(dominfo) else: label = None - security.res_security_check(args[1], label) + + security.res_security_check(args[1], label) return (dom, vbd) --------------050601000701090207030501 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------050601000701090207030501--